Add failing tests for summaries and referencing / invoking static methods of extensions.

scheglov · commit-bot@chromium.org · commit aac3ce55737e · 2019-07-25T19:53:26.000Z
As requested in https://dart-review.googlesource.com/c/sdk/+/110363 R=brianwilkerson@google.com, paulberry@google.com Change-Id: I8f2aba0ea02e4857bba253131d2b73e17eaebcd4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110520 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
diff --git a/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart b/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
@@ -40,8 +40,8 @@ class ResynthesizeAstStrongTest extends ResynthesizeTestStrategyTwoPhase
 
   @override
   @failingTest
-  test_defaultValue_refersToExtension_method() async {
-    await super.test_defaultValue_refersToExtension_method();
+  test_defaultValue_refersToExtension_method_inside() async {
+    await super.test_defaultValue_refersToExtension_method_inside();
   }
 
   @override
diff --git a/pkg/analyzer/test/src/summary/resynthesize_common.dart b/pkg/analyzer/test/src/summary/resynthesize_common.dart
@@ -19,6 +19,7 @@ import 'package:analyzer/src/summary/resynthesize.dart';
 import 'package:analyzer/src/test_utilities/mock_sdk.dart';
 import 'package:analyzer/src/test_utilities/resource_provider_mixin.dart';
 import 'package:test/test.dart';
+import 'package:test_reflective_loader/test_reflective_loader.dart';
 
 import '../../util/element_type_matchers.dart';
 import 'element_text.dart';
@@ -3608,6 +3609,28 @@ const int Function(int, String) V =
 ''');
   }
 
+  @FailingTest(reason: 'Resolution is not implemented yet for extensions')
+  test_const_reference_staticMethod_ofExtension() async {
+    featureSet = enableExtensionMethods;
+    var library = await checkLibrary('''
+class A {}
+extension E on A {
+  static void f() {}
+}
+const x = E.f;
+''');
+    checkElementText(library, r'''
+class A {
+}
+extension E on A {
+  static void f() {}
+}
+const void Function() x =
+        E/*location: test.dart;E*/.
+        f/*location: test.dart;E;f*/;
+''');
+  }
+
   test_const_reference_topLevelFunction() async {
     var library = await checkLibrary(r'''
 foo() {}
@@ -5124,7 +5147,7 @@ void defaultF<T>(T v) {}
 ''');
   }
 
-  test_defaultValue_refersToExtension_method() async {
+  test_defaultValue_refersToExtension_method_inside() async {
     featureSet = enableExtensionMethods;
     var library = await checkLibrary('''
 class A {}
@@ -5133,18 +5156,15 @@ extension E on A {
   static void g([Object p = f]) {}
 }
 ''');
-    checkElementText(
-        library,
-        r'''
+    checkElementText(library, r'''
 class A {
 }
 extension E on A {
   static void f() {}
   static void g([Object p =
         f/*location: test.dart;E;f*/]) {}
 }
-''',
-        withTypes: true);
+''');
   }
 
   test_defaultValue_refersToGenericClass() async {
@@ -10845,6 +10865,26 @@ final int v;
 ''');
   }
 
+  @FailingTest(reason: 'Resolution is not implemented yet for extensions')
+  test_variable_initializer_staticMethod_ofExtension() async {
+    featureSet = enableExtensionMethods;
+    var library = await checkLibrary('''
+class A {}
+extension E on A {
+  static int f() => 0;
+}
+var x = E.f();
+''');
+    checkElementText(library, r'''
+class A {
+}
+extension E on A {
+  static int f() {}
+}
+int x;
+''');
+  }
+
   test_variable_initializer_untyped() async {
     var library = await checkLibrary('var v = 0;');
     checkElementText(library, r'''

Original file line number	Diff line number	Diff line change
`@@ -40,8 +40,8 @@ class ResynthesizeAstStrongTest extends ResynthesizeTestStrategyTwoPhase`
`40`	`40`
`41`	`41`	`@override`
`42`	`42`	`@failingTest`
`43`		`- test_defaultValue_refersToExtension_method() async {`
`44`		`- await super.test_defaultValue_refersToExtension_method();`
	`43`	`+ test_defaultValue_refersToExtension_method_inside() async {`
	`44`	`+ await super.test_defaultValue_refersToExtension_method_inside();`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`@override`