Issue 38506. Don't attempt to use LibraryElement.metadata for not the first LibraryDirective.

scheglov · commit-bot@chromium.org · commit aa0cf44b05a2 · 2019-11-18T15:28:45.000Z
R=brianwilkerson@google.com Bug: #38506 Change-Id: Ib76b1e81554f061622ec98fae21b4dd9a1280c24 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125521 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
diff --git a/pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart b/pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart
@@ -61,6 +61,10 @@ class ResolutionVisitor extends RecursiveAstVisitor<void> {
   final AstRewriter _astRewriter;
   final TypeNameResolver _typeNameResolver;
 
+  /// This index is incremented every time we visit a [LibraryDirective].
+  /// There is just one [LibraryElement], so we can support only one node.
+  int _libraryDirectiveIndex = 0;
+
   /// The provider of pre-built children elements from the element being
   /// visited. For example when we visit a method, its element is resynthesized
   /// from the summary, and we get resynthesized elements for type parameters
@@ -735,8 +739,13 @@ class ResolutionVisitor extends RecursiveAstVisitor<void> {
   @override
   void visitLibraryDirective(LibraryDirective node) {
     super.visitLibraryDirective(node);
-    if (node.element != null) {
+    ++_libraryDirectiveIndex;
+    if (node.element != null && _libraryDirectiveIndex == 1) {
       _setElementAnnotations(node.metadata, node.element.metadata);
+    } else {
+      for (var annotation in node.metadata) {
+        annotation.elementAnnotation = ElementAnnotationImpl(_unitElement);
+      }
     }
   }
 
diff --git a/pkg/analyzer/test/generated/invalid_code_test.dart b/pkg/analyzer/test/generated/invalid_code_test.dart
@@ -202,6 +202,17 @@ class B {}
     await _assertCanBeAnalyzed(r'c(=k(<)>');
   }
 
+  test_fuzz_38506() async {
+    // https://github.com/dart-lang/sdk/issues/38506
+    // We have only one LibraryElement to get resolved annotations.
+    // Leave annotations node of other LibraryDirective(s) unresolved.
+    await _assertCanBeAnalyzed(r'''
+library c;
+@foo
+library c;
+''');
+  }
+
   test_genericFunction_asTypeArgument_ofUnresolvedClass() async {
     await _assertCanBeAnalyzed(r'''
 C<int Function()> c;
