Skip to content

Commit a244295

Browse files
scheglovcommit-bot@chromium.org
authored andcommitted
Tests for AstRewriteVisitor.
[email protected] Change-Id: I811b2722cb78572bfabdf1fe4dd2c766f128736e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112604 Commit-Queue: Konstantin Shcheglov <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
1 parent 8af17ed commit a244295

File tree

5 files changed

+404
-13
lines changed

5 files changed

+404
-13
lines changed

pkg/analyzer/lib/src/dart/resolver/ast_rewrite.dart

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,11 @@
33
// BSD-style license that can be found in the LICENSE file.
44

55
import 'package:analyzer/dart/ast/ast.dart';
6-
import 'package:analyzer/dart/ast/ast_factory.dart';
6+
import 'package:analyzer/dart/ast/standard_ast_factory.dart';
77
import 'package:analyzer/dart/ast/token.dart';
88
import 'package:analyzer/dart/element/element.dart';
99
import 'package:analyzer/dart/element/type.dart';
1010
import 'package:analyzer/error/listener.dart';
11-
import 'package:analyzer/src/dart/ast/ast_factory.dart';
1211
import 'package:analyzer/src/dart/ast/token.dart';
1312
import 'package:analyzer/src/dart/ast/utilities.dart';
1413
import 'package:analyzer/src/dart/element/type.dart';
@@ -56,7 +55,6 @@ class AstRewriteVisitor extends ScopedVisitor {
5655
}
5756
Element element = nameScope.lookup(methodName, definingLibrary);
5857
if (element is ClassElement) {
59-
AstFactory astFactory = new AstFactoryImpl();
6058
TypeName typeName = astFactory.typeName(methodName, node.typeArguments);
6159
ConstructorName constructorName =
6260
astFactory.constructorName(typeName, null, null);
@@ -65,7 +63,6 @@ class AstRewriteVisitor extends ScopedVisitor {
6563
_getKeyword(node), constructorName, node.argumentList);
6664
NodeReplacer.replace(node, instanceCreationExpression);
6765
} else if (element is ExtensionElement) {
68-
AstFactory astFactory = new AstFactoryImpl();
6966
ExtensionOverride extensionOverride = astFactory.extensionOverride(
7067
extensionName: methodName,
7168
typeArguments: node.typeArguments,
@@ -91,10 +88,10 @@ class AstRewriteVisitor extends ScopedVisitor {
9188
typeArguments,
9289
[element.name, constructorElement.name]);
9390
}
94-
AstFactory astFactory = new AstFactoryImpl();
9591
TypeName typeName = astFactory.typeName(target, null);
9692
ConstructorName constructorName =
9793
astFactory.constructorName(typeName, node.operator, methodName);
94+
// TODO(scheglov) I think we should drop "typeArguments" below.
9895
InstanceCreationExpression instanceCreationExpression =
9996
astFactory.instanceCreationExpression(
10097
_getKeyword(node), constructorName, node.argumentList,
@@ -103,7 +100,6 @@ class AstRewriteVisitor extends ScopedVisitor {
103100
}
104101
} else if (element is PrefixElement) {
105102
// Possible cases: p.C() or p.C<>()
106-
AstFactory astFactory = new AstFactoryImpl();
107103
Identifier identifier = astFactory.prefixedIdentifier(
108104
astFactory.simpleIdentifier(target.token),
109105
null,
@@ -120,7 +116,6 @@ class AstRewriteVisitor extends ScopedVisitor {
120116
_getKeyword(node), constructorName, node.argumentList);
121117
NodeReplacer.replace(node, instanceCreationExpression);
122118
} else if (prefixedElement is ExtensionElement) {
123-
AstFactory astFactory = new AstFactoryImpl();
124119
PrefixedIdentifier extensionName =
125120
astFactory.prefixedIdentifier(target, node.operator, methodName);
126121
ExtensionOverride extensionOverride = astFactory.extensionOverride(
@@ -147,7 +142,6 @@ class AstRewriteVisitor extends ScopedVisitor {
147142
typeArguments,
148143
[element.name, constructorElement.name]);
149144
}
150-
AstFactory astFactory = new AstFactoryImpl();
151145
TypeName typeName = astFactory.typeName(target, typeArguments);
152146
ConstructorName constructorName =
153147
astFactory.constructorName(typeName, node.operator, methodName);

0 commit comments

Comments
 (0)