[vm/ffi] Delete helper thread in ffi/function_gc_test

sjindel-google · commit-bot@chromium.org · commit a05f5910fa7c · 2019-08-08T18:16:39.000Z
Fixes memory leak on ASAN bot. Change-Id: Idbfd1e66b703e1203fec027a040147179dd0752d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112343 Auto-Submit: Samir Jindel <sjindel@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Samir Jindel <sjindel@google.com>
diff --git a/runtime/bin/ffi_test/ffi_test_functions.cc b/runtime/bin/ffi_test/ffi_test_functions.cc
@@ -575,6 +575,7 @@ DART_EXPORT void* UnprotectCode() {
 DART_EXPORT void WaitForHelper(void* helper) {
   std::thread* thread = reinterpret_cast<std::thread*>(helper);
   thread->join();
+  delete thread;
 }
 #else
 // Our version of VSC++ doesn't support std::thread yet.

Original file line number	Diff line number	Diff line change
`@@ -575,6 +575,7 @@ DART_EXPORT void* UnprotectCode() {`
`575`	`575`	`DART_EXPORT void WaitForHelper(void* helper) {`
`576`	`576`	`std::thread* thread = reinterpret_cast<std::thread*>(helper);`
`577`	`577`	`thread->join();`
	`578`	`+ delete thread;`
`578`	`579`	`}`
`579`	`580`	`#else`
`580`	`581`	`// Our version of VSC++ doesn't support std::thread yet.`