Skip to content

Commit 9f79dfc

Browse files
srujzscommit-bot@chromium.org
srujzs
authored and
[email protected]
committed
Address analyzer errors in golden files in dart:html
New analyzer errors are reported for dart:html around nullability. Non-nullable fields are translated to native getters and setters if part of a concrete class and normal getters and setters if abstract. Change-Id: I2fd87803a08872b2a7eae4de0af704f184997c7e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137481 Reviewed-by: Stephen Adams <[email protected]>
1 parent 80f84e1 commit 9f79dfc

21 files changed

+1420
-751
lines changed

‎pkg/dev_compiler/tool/dart2js_nnbd_sdk_error_golden.txt‎

Lines changed: 0 additions & 147 deletions
Large diffs are not rendered by default.

‎pkg/dev_compiler/tool/dartdevc_nnbd_sdk_error_golden.txt‎

Lines changed: 0 additions & 147 deletions
Large diffs are not rendered by default.

‎sdk/lib/html/dart2js/html_dart2js.dart‎

Lines changed: 463 additions & 143 deletions
Large diffs are not rendered by default.

‎sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1297,5 +1297,5 @@ class VersionChangeEvent extends Event {
12971297
int get oldVersion native;
12981298

12991299
@JSName('target')
1300-
final OpenDBRequest target;
1300+
OpenDBRequest get target native;
13011301
}

‎sdk/lib/web_gl/dart2js/web_gl_dart2js.dart‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,10 @@ class Canvas extends Interceptor {
8888
}
8989

9090
@JSName('canvas')
91-
final CanvasElement canvas;
91+
CanvasElement get canvas native;
9292

9393
@JSName('canvas')
94-
final OffscreenCanvas offscreenCanvas;
94+
OffscreenCanvas get offscreenCanvas native;
9595
}
9696

9797
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

0 commit comments

Comments
 (0)