[nnbd_migration] Handle while loops.

MichaelRFairhurst · commit-bot@chromium.org · commit 998deea3383d · 2019-08-12T22:20:23.000Z
Change-Id: I64fe98087cc5da0a97056f0fa96fffbe9f06326f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112406 Auto-Submit: Mike Fairhurst <mfairhurst@google.com> Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Paul Berry <paulberry@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
diff --git a/pkg/nnbd_migration/lib/src/edge_builder.dart b/pkg/nnbd_migration/lib/src/edge_builder.dart
@@ -1090,8 +1090,8 @@ $stackTrace''');
 
   @override
   DecoratedType visitWhileStatement(WhileStatement node) {
-    // TODO do special condition handling
-    // TODO do create true/false guards?
+    // Note: we do not create guards. A null check here is *very* unlikely to be
+    // unnecessary after analysis.
     _handleAssignment(node.condition, _notNullType);
     _postDominatedLocals.doScoped(action: () => node.body.accept(this));
     return null;
