Add test for incomparable on type resolution and fix expectations.

leafpetersen · leafpetersen · commit 90aca0b8d5a6 · 2019-09-05T22:39:21.000Z
Change-Id: I8c1ead430a866461d802e86a36c892899645faf4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115620 Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
diff --git a/tests/language_2/extension_methods/static_extension_resolution_failures_test.dart b/tests/language_2/extension_methods/static_extension_resolution_failures_test.dart
@@ -22,41 +22,58 @@ main() {
   Expect.equals("EA.v2", a.v2);
   Expect.equals("EB1.v2", b1.v2);
   Expect.equals("EB2.v2", b2.v2);
-  c // Cannot determine which of EB1 and EB2's v2 is more specific
-    .v2 //# 01: compile-time error
-  ;
+  // Cannot determine which of EB1 and EB2's v2 is more specific
+  c.v2;
+  //^^
+  // [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_MEMBER_ACCESS
+  // [cfe] The getter 'v2' isn't defined for the class 'C'.
 
   Expect.equals("EA.v3", a.v3);
   Expect.equals("EA.v3", b1.v3);
   Expect.equals("EA.v3", b2.v3);
   Expect.equals("EA.v3", c.v3);
 
-
   Iterable<num> i_num = <int>[];
   Iterable<int> ii = <int>[];
   List<num> ln = <int>[];
   List<int> li = <int>[];
 
-  i_num // No `i_num` extension declared.
-    .i_num //# 02: compile-time error
-  ;
+  // No `i_num` extension declared.
+  i_num.i_num;
+  //    ^^^^^
+  // [analyzer] STATIC_TYPE_WARNING.UNDEFINED_GETTER
+  // [cfe] The getter 'i_num' isn't defined for the class 'Iterable<num>'.
 
   Expect.equals("Iterable<int>.i_num", ii.i_num);
   Expect.equals("List<num>.i_num", ln.i_num);
 
-  li // Both apply, neither is more specific.
-    .i_num //# 03: compile-time error
-  ;
-
-  c // no most specific because both are equally specific.
-    .cs //# 04: compile-time error
-  ;
+  // Both apply, neither is more specific.
+  li.i_num;
+  // ^^^^^
+  // [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_MEMBER_ACCESS
+  // [cfe] The getter 'i_num' isn't defined for the class 'List<int>'.
+
+  // no most specific because both are equally specific.
+  c.cs;
+  //^^
+  // [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_MEMBER_ACCESS
+  // [cfe] The getter 'cs' isn't defined for the class 'C'.
+
+  // Both EIT.e1 and ELO.e1 apply, but their instantiated on
+  // types are incomparable, and hence this is an error.
+  ln.e1();
+  // ^
+  // [analyzer] unspecified
+  // [cfe] The method 'e1' isn't defined for the class 'List<num>'.
 }
 
 // Diamond class hierarchy.
 class A {}
+
 class B1 implements A {}
+
 class B2 implements A {}
+
 class C implements B1, B2 {}
 
 extension EA on A {
@@ -97,3 +114,11 @@ extension C1 on C {
 extension C2 on C {
   String get cs => "C2.cs";
 }
+
+extension EIT<T> on Iterable<T> {
+  String e1() => "Iterable<T>.e1";
+}
+
+extension ELO on List<Object> {
+  String e1() => "List<Object>.e1";
+}
diff --git a/tests/language_2/extension_methods/static_extension_resolution_test.dart b/tests/language_2/extension_methods/static_extension_resolution_test.dart
@@ -210,16 +210,16 @@ main() {
 
   // Applicable methods.
   Expect.equals("SubTarget<T>.e1", s1.e1());
-  Expect.equals("SubTarget<Object>.e2", s1.e2());
-  Expect.equals("Target<T>.e3", s1.e3());
-  Expect.equals("Target<Object>.e4", s1.e4());
+  Expect.equals("T.e2", s1.e2());
+  Expect.equals("T.e3", s1.e3());
+  Expect.equals("T.e4", s1.e4());
   Expect.equals("T.e5", s1.e5());
   Expect.equals("Object.e6", s1.e6());
 
   Expect.equals("Target<T>.e1", t1.e1());
   Expect.equals("Target<T>.e2", t1.e2());
   Expect.equals("Target<T>.e3", t1.e3());
-  Expect.equals("Target<Object>.e4", t1.e4());
+  Expect.equals("T.e4", t1.e4());
   Expect.equals("T.e5", t1.e5());
   Expect.equals("Object.e6", t1.e6());
 
