[VM interpreter] Use write barrier in implicit setter.

crelier · commit-bot@chromium.org · commit 8cbbd7a7410b · 2018-08-03T21:42:16.000Z
Change-Id: I68351f5e009c1101bd7afc443b1b016197f62032 Reviewed-on: https://dart-review.googlesource.com/68427 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Régis Crelier <regis@google.com>
diff --git a/runtime/vm/interpreter.cc b/runtime/vm/interpreter.cc
@@ -1038,7 +1038,9 @@ DART_NOINLINE bool Interpreter::ProcessInvocation(bool* invoked,
           }
         }
       }
-      reinterpret_cast<RawObject**>(instance->ptr())[offset_in_words] = value;
+      instance->StorePointer(
+          reinterpret_cast<RawObject**>(instance->ptr()) + offset_in_words,
+          value);
       *SP = call_base;
       **SP = null_value;
       *invoked = true;

Original file line number	Diff line number	Diff line change
`@@ -1038,7 +1038,9 @@ DART_NOINLINE bool Interpreter::ProcessInvocation(bool* invoked,`
`1038`	`1038`	`}`
`1039`	`1039`	`}`
`1040`	`1040`	`}`
`1041`		`- reinterpret_cast<RawObject**>(instance->ptr())[offset_in_words] = value;`
	`1041`	`+ instance->StorePointer(`
	`1042`	`+ reinterpret_cast<RawObject**>(instance->ptr()) + offset_in_words,`
	`1043`	`+ value);`
`1042`	`1044`	`*SP = call_base;`
`1043`	`1045`	`**SP = null_value;`
`1044`	`1046`	`*invoked = true;`