[vm] escape path when creating process on Windows

zichangg · commit-bot@chromium.org · commit 8a0ae573a1ae · 2019-08-08T19:10:01.000Z
path may contain spaces. When it is passed into CreatProcessW, it will interpret in several ways. Escape path for CreateProcessW to remove ambiguity. The api doc of CreateProcessW: https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-createprocessw#parameters Bug: #37751 Change-Id: Ia3486d9a8c6b38c526c651dd6a801e0b8dad8655 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112267 Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Zichang Guo <zichangguo@google.com>
diff --git a/runtime/bin/process_patch.dart b/runtime/bin/process_patch.dart
@@ -233,7 +233,14 @@ class _ProcessImpl extends _ProcessImplNativeWrapper implements Process {
     if (path is! String) {
       throw new ArgumentError("Path is not a String: $path");
     }
-    _path = path;
+
+    if (Platform.isWindows) {
+      // Escape paths that may contain spaces
+      // Bug: https://github.com/dart-lang/sdk/issues/37751
+      _path = _windowsArgumentEscape(path);
+    } else {
+      _path = path;
+    }
 
     if (arguments is! List) {
       throw new ArgumentError("Arguments is not a List: $arguments");
