Flow analysis: Remove unnecessary arg to ifStatement_thenBegin

stereotype441 · commit-bot@chromium.org · commit 842812dd0bd9 · 2019-07-20T05:01:43.000Z
Change-Id: I56242547905825108759ef015ec96668bf75d8d2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109742 Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
diff --git a/pkg/analyzer/lib/src/dart/resolver/flow_analysis.dart b/pkg/analyzer/lib/src/dart/resolver/flow_analysis.dart
@@ -347,7 +347,7 @@ class FlowAnalysis<Statement, Expression, Element, Type> {
     _current = _join(afterThen, afterElse);
   }
 
-  void ifStatement_thenBegin(Statement ifStatement, Expression condition) {
+  void ifStatement_thenBegin(Expression condition) {
     _conditionalEnd(condition);
     // Tail of the stack:  falseCondition, trueCondition
 
diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart
@@ -4711,7 +4711,7 @@ class ResolverVisitor extends ScopedVisitor {
 
     Statement thenStatement = node.thenStatement;
     if (_flowAnalysis != null) {
-      _flowAnalysis.flow.ifStatement_thenBegin(node, condition);
+      _flowAnalysis.flow.ifStatement_thenBegin(condition);
       visitStatementInScope(thenStatement);
     } else {
       _promoteManager.visitIfStatement_thenStatement(

Original file line number	Diff line number	Diff line change
`@@ -347,7 +347,7 @@ class FlowAnalysis<Statement, Expression, Element, Type> {`
`347`	`347`	`_current = _join(afterThen, afterElse);`
`348`	`348`	`}`
`349`	`349`
`350`		`- void ifStatement_thenBegin(Statement ifStatement, Expression condition) {`
	`350`	`+ void ifStatement_thenBegin(Expression condition) {`
`351`	`351`	`_conditionalEnd(condition);`
`352`	`352`	`// Tail of the stack: falseCondition, trueCondition`
`353`	`353`