Issue 38878. Update SuperContext for annotations.

scheglov · scheglov · commit 7df44023f458 · 2019-11-18T19:06:48.000Z
R=brianwilkerson@google.com Bug: #38878 Change-Id: Ib2944fd60062fca0ec2899d83656cdc02b0a4a87 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125529 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
diff --git a/pkg/analyzer/lib/src/generated/super_context.dart b/pkg/analyzer/lib/src/generated/super_context.dart
@@ -6,6 +6,10 @@ import 'package:analyzer/dart/ast/ast.dart';
 
 /// An indication of the kind of context in which a super expression was found.
 class SuperContext {
+  /// An indication that the super expression is in a context in which it is
+  /// invalid because it is in an annotation.
+  static const SuperContext annotation = SuperContext._('annotation');
+
   /// An indication that the super expression is in a context in which it is
   /// invalid because it is in an instance member of an extension.
   static const SuperContext extension = SuperContext._('extension');
@@ -25,7 +29,9 @@ class SuperContext {
   /// being used.
   factory SuperContext.of(SuperExpression expression) {
     for (AstNode node = expression; node != null; node = node.parent) {
-      if (node is CompilationUnit) {
+      if (node is Annotation) {
+        return SuperContext.annotation;
+      } else if (node is CompilationUnit) {
         return SuperContext.static;
       } else if (node is ConstructorDeclaration) {
         return node.factoryKeyword == null
diff --git a/pkg/analyzer/test/generated/invalid_code_test.dart b/pkg/analyzer/test/generated/invalid_code_test.dart
@@ -224,6 +224,16 @@ part '${[for(var v = 0;;) v]}';
 ''');
   }
 
+  test_fuzz_38878() async {
+    // We should not attempt to resolve `super` in annotations.
+    await _assertCanBeAnalyzed(r'''
+class C {
+  @A(super.f())
+  f(int x) {}
+}
+''');
+  }
+
   test_genericFunction_asTypeArgument_ofUnresolvedClass() async {
     await _assertCanBeAnalyzed(r'''
 C<int Function()> c;
