Skip to content

Commit 76f82bd

Browse files
fishythefishcommit-bot@chromium.org
fishythefish
authored and
[email protected]
committed
[dart2js] Split up runtime_types.
This is a first pass at breaking up runtime_types.dart. runtime_types_resolution.dart contains the former parts of runtime_types that runtime_types_new depends on (namely, RuntimeTypesNeed and RuntimeTypesSubstitutions), as well as their transitive dependencies. This leaves just the code responsible for encoding the old type representation in runtime_types, mirroring what we have in runtime_types_new. As a result, both runtime_types and runtime_types_new have runtime_types_resolution as a common dependency, but runtime_types_resolution does not depend on a particular encoding. However, runtime_types_resolution is still over 2.5 KLOC and still depends on the old TypeCheck representation. Change-Id: I22d932d2695cb573c2a3b4dafe5132d4e424fa77 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109557 Commit-Queue: Mayank Patke <[email protected]> Reviewed-by: Johnni Winther <[email protected]>
1 parent 0352fb2 commit 76f82bd

25 files changed

+1500
-1532
lines changed

‎pkg/compiler/lib/src/js_backend/backend.dart‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import 'annotations.dart';
2020
import 'checked_mode_helpers.dart';
2121
import 'namer.dart';
2222
import 'runtime_types.dart';
23+
import 'runtime_types_codegen.dart';
2324
import 'runtime_types_new.dart';
2425

2526
abstract class FunctionCompiler {

‎pkg/compiler/lib/src/js_backend/codegen_listener.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import '../universe/world_impact.dart'
2020
import 'backend_impact.dart';
2121
import 'backend_usage.dart';
2222
import 'custom_elements_analysis.dart';
23-
import 'runtime_types.dart';
23+
import 'runtime_types_resolution.dart';
2424

2525
class CodegenEnqueuerListener extends EnqueuerListener {
2626
final ElementEnvironment _elementEnvironment;

‎pkg/compiler/lib/src/js_backend/constant_emitter.dart‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import '../options.dart';
1818
import 'field_analysis.dart' show JFieldAnalysis;
1919
import 'runtime_types.dart';
2020
import 'runtime_types_new.dart' show RecipeEncoder;
21+
import 'runtime_types_resolution.dart';
2122

2223
typedef jsAst.Expression _ConstantReferenceGenerator(ConstantValue constant);
2324

‎pkg/compiler/lib/src/js_backend/impact_transformer.dart‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ import 'interceptor_data.dart';
3333
import 'namer.dart';
3434
import 'native_data.dart';
3535
import 'runtime_types.dart';
36+
import 'runtime_types_resolution.dart';
3637

3738
class JavaScriptImpactTransformer extends ImpactTransformer {
3839
final ElementEnvironment _elementEnvironment;

0 commit comments

Comments
 (0)