Repository navigation
Commit 6867425
Migration: add a more robust assertion to the DecoratedType constructor
This CL takes https://dart-review.googlesource.com/c/sdk/+/107740
and add the following condition so that all the current tests pass.
if (positionalParameters.length <= positionalParameterCount) {
// TODO(danrubel): Track down why this happens
// and remove this if statement
} else {
...
My next task is to track down and fix the underlying issue
then remove the temporary code above from the asserts.
Change-Id: I683beac46835ed7b8c1a7b856804db84a74142f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107860
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Dan Rubel <[email protected]>1 parent 2fd4ca5 commit 6867425
1 file changed
Lines changed: 46 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
44 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
45 | 89 | | |
46 | 90 | | |
47 | 91 | | |
| |||
0 commit comments