Simplify TestTypeProvider constructor.

stereotype441 · commit-bot@chromium.org · commit 6317779f9b9a · 2019-11-08T13:53:17.000Z
The only optional parameter that was actually used was nullabilitySuffix, so eliminate the others, and make it a named parameter for easier future expansion. Change-Id: Iee05e955a1c996b4e1dd9bbec3db7fd1588ebe04 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124001 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
diff --git a/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart b/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart
@@ -15,12 +15,10 @@ import 'package:analyzer/src/test_utilities/mock_sdk_elements.dart';
  * for the core library.
  */
 class TestTypeProvider extends TypeProviderImpl {
-  factory TestTypeProvider([
-    AnalysisContext context,
-    Object analysisDriver,
+  factory TestTypeProvider({
     NullabilitySuffix nullabilitySuffix = NullabilitySuffix.star,
-  ]) {
-    context ??= _MockAnalysisContext();
+  }) {
+    var context = _MockAnalysisContext();
     var sdkElements = MockSdkElements(context, nullabilitySuffix);
     return TestTypeProvider._(
       nullabilitySuffix,
diff --git a/pkg/analyzer/test/src/dart/element/type_algebra_test.dart b/pkg/analyzer/test/src/dart/element/type_algebra_test.dart
@@ -387,8 +387,9 @@ class _Base with ElementsTypesMixin {
   final bool useNnbd;
 
   _Base({this.useNnbd = false})
-      : typeProvider = TestTypeProvider(null, null,
-            useNnbd ? NullabilitySuffix.none : NullabilitySuffix.question);
+      : typeProvider = TestTypeProvider(
+            nullabilitySuffix:
+                useNnbd ? NullabilitySuffix.none : NullabilitySuffix.question);
 
   InterfaceType get boolType => typeProvider.boolType;
 
