[vm] correctly create connection errors

tamird · commit-bot@chromium.org · commit 55a4ee8a5d21 · 2019-07-24T19:46:38.000Z
When sourceAddress is null, there is no bind call, so the error cannot possibly be a bind failure. Change-Id: Idec2aff48c436b89f9b571458d0fbce700793d33 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110184 Commit-Queue: Zach Anderson <zra@google.com> Reviewed-by: Zach Anderson <zra@google.com> Auto-Submit: Tamir Duberstein <tamird@google.com>
diff --git a/runtime/bin/socket_patch.dart b/runtime/bin/socket_patch.dart
@@ -475,7 +475,9 @@ class _NativeSocket extends _NativeSocketNativeWrapper with _ServiceObject {
           // Keep first error, if present.
           if (error == null) {
             int errorCode = result.errorCode;
-            if (errorCode != null && socket.isBindError(errorCode)) {
+            if (sourceAddress != null &&
+                errorCode != null &&
+                socket.isBindError(errorCode)) {
               error = createError(result, "Bind failed", sourceAddress);
             } else {
               error = createError(result, "Connection failed", address, port);
