Expire constant-update-2018 flag.

askeksa · commit-bot@chromium.org · commit 528292bd3067 · 2019-08-16T13:48:27.000Z
All uses of no-constant-update-2018 in the Dart SDK, Flutter and Fuchsia have been cleaned out, which means we can expire the flag. Closes #37874 Change-Id: Ie31dfbf87db52d37fdf4218afa8c6f7a894bafff Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113182 Reviewed-by: Dan Rubel <danrubel@google.com> Commit-Queue: Aske Simon Christensen <askesc@google.com>
diff --git a/pkg/analyzer/lib/src/dart/analysis/experiments.g.dart b/pkg/analyzer/lib/src/dart/analysis/experiments.g.dart
@@ -180,7 +180,7 @@ class IsEnabledByDefault {
 /// value in [IsEnabledByDefault]).
 class IsExpired {
   /// Expiration status of the experiment "constant-update-2018"
-  static const bool constant_update_2018 = false;
+  static const bool constant_update_2018 = true;
 
   /// Expiration status of the experiment "control-flow-collections"
   static const bool control_flow_collections = false;
diff --git a/pkg/front_end/lib/src/api_prototype/experimental_flags.dart b/pkg/front_end/lib/src/api_prototype/experimental_flags.dart
@@ -48,7 +48,7 @@ const Map<ExperimentalFlag, bool> defaultExperimentalFlags = {
 };
 
 const Map<ExperimentalFlag, bool> expiredExperimentalFlags = {
-  ExperimentalFlag.constantUpdate2018: false,
+  ExperimentalFlag.constantUpdate2018: true,
   ExperimentalFlag.controlFlowCollections: false,
   ExperimentalFlag.extensionMethods: false,
   ExperimentalFlag.nonNullable: false,
diff --git a/tools/experimental_features.yaml b/tools/experimental_features.yaml
@@ -70,10 +70,6 @@
 # a warning that the experiment has been retired or rejected, but the tool
 # should continue to run.
 
-constant-update-2018:
-  help: "Enhanced constant expressions"
-  enabledIn: '2.4.1'
-
 extension-methods:
   help: "Extension Methods"
 
@@ -88,6 +84,11 @@ triple-shift:
 # on the command line, and will eventually be removed.
 #
 
+constant-update-2018:
+  help: "Enhanced constant expressions"
+  enabledIn: '2.4.1'
+  expired: true
+
 control-flow-collections:
   help: "Control Flow Collections"
   enabledIn: '2.2.2'
