Skip to content

Commit 46743f3

Browse files
whessecommit-bot@chromium.org
whesse
authored and
[email protected]
committed
Remove $runtime == drt sections and uses of drt from status files.
Change-Id: Iffd934a67668901176a84c9b01512711a011652d Reviewed-on: https://dart-review.googlesource.com/67803 Reviewed-by: Alexander Thomas <[email protected]> Commit-Queue: William Hesse <[email protected]>
1 parent 637e55d commit 46743f3

File tree

18 files changed

+160
-1903
lines changed

18 files changed

+160
-1903
lines changed

‎pkg/pkg.status‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -209,9 +209,6 @@ front_end/test/src/base/uri_resolver_test: SkipByDesign # Relies on access to fi
209209
[ $compiler == dart2js && $runtime != d8 ]
210210
front_end/test/mixin_export_test: RuntimeError # Issue 30576
211211

212-
[ $compiler == dart2js && $runtime == drt ]
213-
async/test/stream_zip_test: RuntimeError, Pass # Issue 18548
214-
215212
[ $compiler == dart2js && $browser ]
216213
crypto/test/sha1_test: Slow, Pass
217214
crypto/test/sha256_test: Slow, Pass
@@ -229,11 +226,6 @@ status_file/test/status_expression_dnf_test: RuntimeError # not strong-clean
229226
async/test/stream_zip_test: SkipSlow # Times out. Issue 22050
230227
collection/test/unmodifiable_collection_test: SkipSlow # Times out. Issue 22050
231228

232-
[ $compiler == none && $runtime == drt ]
233-
front_end/*: SkipByDesign
234-
mutation_observer: Skip # Issue 21149
235-
unittest/*: Skip # Issue 21949
236-
237229
[ $runtime == vm && $system == windows ]
238230
analysis_server/test/analysis/get_errors_test: Skip # runtime error, Issue 22180
239231
analysis_server/test/benchmarks_test: RuntimeError # Issue 32355

‎pkg/status_file/test/data/co19-dart2js.status‎

Lines changed: 3 additions & 899 deletions
Large diffs are not rendered by default.

‎pkg/status_file/test/data/vm.status‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,6 @@ cc/Profiler_SourcePositionOptimized: Skip
105105
cc/Profiler_BinaryOperatorSourcePosition: Skip
106106
cc/Profiler_BinaryOperatorSourcePositionOptimized: Skip
107107

108-
[ $compiler == none && $runtime == drt ]
109-
dart/truncating_ints_test: Skip # Issue 14651
110-
111108
[ $compiler == dart2js ]
112109
dart/redirection_type_shuffling_test: Skip # Depends on lazy enforcement of type bounds
113110
dart/byte_array_test: Skip # compilers not aware of byte arrays

‎runtime/observatory/tests/observatory_ui/observatory_ui.status‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
# for details. All rights reserved. Use of this source code is governed by a
33
# BSD-style license that can be found in the LICENSE file.
44

5-
[ $runtime == drt || !$browser || $fast_startup ]
6-
*: SkipByDesign
7-
85
# custom elements are not supported on old browsers, we don't
96
# intend for observatory to work on old browser versions, so
107
# skipping.
118
[ $runtime == ff || $runtime == ie10 || $runtime == ie11 || $runtime == safari ]
129
*: SkipByDesign
10+
11+
[ !$browser || $fast_startup ]
12+
*: SkipByDesign

‎runtime/tests/vm/vm.status‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -252,9 +252,6 @@ dart/issue32950_test: SkipByDesign # uses spawnUri.
252252
dart/redirection_type_shuffling_test: SkipByDesign # Includes dart:mirrors.
253253
dart/spawn_shutdown_test: SkipSlow
254254

255-
[ $compiler == none && $runtime == drt ]
256-
dart/truncating_ints_test: Skip # Issue 14651
257-
258255
[ $mode == debug && $system == windows ]
259256
dart/spawn_shutdown_test: Skip # Flaky crashes unable to start thread; likely low memory on the bot.
260257

‎samples-dev/samples-dev.status‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,5 @@ swarm/test/swarm_ui_lib/touch/touch_test: Fail # This may be related to issue 15
2323
swarm/test/swarm_test: Fail # TODO(kasperl): Please triage.
2424
swarm/test/swarm_ui_lib/layout/layout_test: Fail # TODO(kasperl): Please triage.
2525

26-
[ $compiler == dart2js && $runtime == drt ]
27-
swarm/test/swarm_test: Pass, Crash, Fail # Issue 10950
28-
29-
[ $compiler == dart2js && $runtime == drt && $system == windows ]
30-
swarm/test/swarm_test: Fail # Issue 4517
31-
3226
[ $compiler == dart2js && $runtime == ff ]
3327
swarm/test/swarm_test: Fail # Issue 5633

‎tests/co19/co19-dart2js.status‎

Lines changed: 117 additions & 902 deletions
Large diffs are not rendered by default.

‎tests/compiler/dart2js_extra/dart2js_extra.status‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,10 @@ int_index_test/02: MissingCompileTimeError
117117
local_signature_test: RuntimeError # Test against function type variables is only supported in strong mode.
118118
switch_test/00: MissingCompileTimeError
119119

120-
[ $compiler == dart2js && ($runtime == chrome || $runtime == chromeOnAndroid || $runtime == drt || $runtime == ff || $runtime == safari) ]
120+
[ $compiler == dart2js && ($runtime == chrome || $runtime == chromeOnAndroid || $runtime == ff || $runtime == safari) ]
121121
isolate2_test/01: Fail # Issue 14458.
122122

123-
[ $compiler == dart2js && ($runtime == drt || $runtime == ff || $runtime == jsshell || $runtime == safari) ]
123+
[ $compiler == dart2js && ($runtime == ff || $runtime == jsshell || $runtime == safari) ]
124124
code_motion_exception_test: Skip # Required V8 specific format of JavaScript errors.
125125

126126
[ $compiler == dart2js && ($browser || $host_checked) ]

‎tests/corelib/corelib.status‎

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -126,12 +126,6 @@ string_trimlr_test/unicode63: RuntimeError # Uses Unicode 6.2.0 or earlier.
126126
[ $compiler == dart2js && $runtime != d8 ]
127127
main_test: RuntimeError
128128

129-
[ $compiler == dart2js && $runtime == drt ]
130-
string_trimlr_test/unicode63: RuntimeError # Uses Unicode 6.2.0 or earlier.
131-
132-
[ $compiler == dart2js && $runtime == drt && $csp && $minified ]
133-
core_runtime_types_test: Pass, Fail # Issue 27913
134-
135129
[ $compiler == dart2js && $runtime == none ]
136130
*: Fail, Pass # TODO(ahe): Triage these tests.
137131

@@ -425,10 +419,6 @@ symbol_test/01: MissingCompileTimeError
425419
[ $runtime != d8 && $runtime != dart_precompiled && $runtime != vm ]
426420
regexp/*: Skip # The regexp tests are not verified to work on non d8/vm platforms yet.
427421

428-
[ $runtime != drt && ($compiler == app_jit || $compiler == none || $compiler == precompiler) ]
429-
symbol_test/02: MissingCompileTimeError # bug 11669
430-
symbol_test/03: MissingCompileTimeError # bug 11669
431-
432422
[ $arch == simdbc || $arch == simdbc64 ]
433423
regexp/stack-overflow_test: RuntimeError, OK # Smaller limit with irregex interpreter
434424

@@ -445,6 +435,8 @@ symbol_reserved_word_test/09: RuntimeError # bug 11669
445435
symbol_reserved_word_test/10: MissingCompileTimeError # bug 11669, 19972
446436
symbol_reserved_word_test/12: RuntimeError # bug 11669
447437
symbol_test/01: Fail, Pass # bug 11669
438+
symbol_test/02: MissingCompileTimeError # bug 11669
439+
symbol_test/03: MissingCompileTimeError # bug 11669
448440
symbol_test/none: Fail # bug 11669
449441
unicode_test: Fail # Bug 6706
450442

‎tests/corelib_2/corelib_2.status‎

Lines changed: 16 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -280,21 +280,6 @@ string_base_vm_static_test: MissingCompileTimeError
280280
string_replace_static_test: MissingCompileTimeError
281281
string_static_test: MissingCompileTimeError
282282

283-
[ ($compiler == dartk || $compiler == dartkb) && $mode == release && $hot_reload ]
284-
bigint_parse_radix_test: Crash
285-
286-
# ===== dartk + vm status lines =====
287-
[ ($compiler == dartk || $compiler == dartkb) && $runtime == vm && $strong ]
288-
iterable_fold_test/02: RuntimeError
289-
iterable_reduce_test/01: CompileTimeError # Issue 31533
290-
iterable_reduce_test/none: RuntimeError
291-
symbol_operator_test/03: RuntimeError # Issues 11669 and 31936 - throwing const constructors.
292-
symbol_reserved_word_test/06: RuntimeError # Issues 11669 and 31936 - throwing const constructors.
293-
symbol_reserved_word_test/09: RuntimeError # Issues 11669 and 31936 - throwing const constructors.
294-
symbol_reserved_word_test/12: RuntimeError # Issues 11669 and 31936 - throwing const constructors.
295-
symbol_test/none: RuntimeError # Issues 11669 and 31936 - throwing const constructors.
296-
unicode_test: RuntimeError # Issue 18061: German double S.
297-
298283
[ $compiler != dartk && $runtime == vm && $checked ]
299284
apply_test/01: RuntimeError
300285

@@ -311,11 +296,6 @@ symbol_reserved_word_test/12: RuntimeError # Issues 11669 and 31936 - throwing c
311296
symbol_test/none: RuntimeError # Issues 11669 and 31936 - throwing const constructors.
312297
unicode_test: RuntimeError # Issue 18061: German double S.
313298

314-
[ $compiler == none && $runtime == drt ]
315-
string_from_environment2_test: Skip
316-
string_from_environment3_test: Skip
317-
string_from_environment_test: Skip
318-
319299
[ $compiler == none && $runtime == vm ]
320300
from_environment_const_type_undefined_test/09: MissingCompileTimeError
321301
from_environment_const_type_undefined_test/11: MissingCompileTimeError
@@ -353,14 +333,14 @@ iterable_to_set_test: RuntimeError # is-checks do not implement strong mode type
353333
iterable_generate_test/01: RuntimeError
354334
splay_tree_from_iterable_test: RuntimeError
355335

336+
[ $mode == release && $hot_reload && ($compiler == dartk || $compiler == dartkb) ]
337+
bigint_parse_radix_test: Crash
338+
356339
[ $runtime == dart_precompiled && $minified ]
357340
apply_test: Skip # Uses new Symbol via symbolMapToStringMap helper
358341
error_stack_trace1_test: Skip # Expects unobfuscated stack trace
359342

360-
[ $runtime == drt && ($compiler == dart2js || $compiler == dartdevc || $compiler == dartdevk) ]
361-
string_trimlr_test/unicode63: RuntimeError # Uses Unicode 6.2.0 or earlier.
362-
363-
[ $runtime != drt && ($compiler == app_jit || $compiler == none || $compiler == precompiler) ]
343+
[ $compiler == app_jit || $compiler == none || $compiler == precompiler ]
364344
symbol_test/02: MissingCompileTimeError # Issue 11669
365345
symbol_test/03: MissingCompileTimeError # Issue 11669
366346

@@ -381,6 +361,18 @@ integer_parsed_mul_div_vm_test: RuntimeError # Issue 29921
381361
regress_r21715_test: RuntimeError # Requires fixed-size int64 support.
382362
typed_data_with_limited_ints_test: Skip # Requires fixed-size int64 support.
383363

364+
# ===== dartk + vm status lines =====
365+
[ $runtime == vm && $strong && ($compiler == dartk || $compiler == dartkb) ]
366+
iterable_fold_test/02: RuntimeError
367+
iterable_reduce_test/01: CompileTimeError # Issue 31533
368+
iterable_reduce_test/none: RuntimeError
369+
symbol_operator_test/03: RuntimeError # Issues 11669 and 31936 - throwing const constructors.
370+
symbol_reserved_word_test/06: RuntimeError # Issues 11669 and 31936 - throwing const constructors.
371+
symbol_reserved_word_test/09: RuntimeError # Issues 11669 and 31936 - throwing const constructors.
372+
symbol_reserved_word_test/12: RuntimeError # Issues 11669 and 31936 - throwing const constructors.
373+
symbol_test/none: RuntimeError # Issues 11669 and 31936 - throwing const constructors.
374+
unicode_test: RuntimeError # Issue 18061: German double S.
375+
384376
[ $runtime == vm && !$strong ]
385377
collection_of_test: RuntimeError
386378

0 commit comments

Comments
 (0)