Revert "[vm] escape path when creating process on Windows"

zichangg · commit-bot@chromium.org · commit 45f892df68a0 · 2019-08-13T16:38:00.000Z
This reverts commit 8a0ae57. Reason for revert: Block 'flutter upgrade'. The manual escaped string should be escaped again. Original change's description: > [vm] escape path when creating process on Windows > > path may contain spaces. When it is passed into CreatProcessW, it will interpret in several ways. Escape path for CreateProcessW to remove ambiguity. > The api doc of CreateProcessW: https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-createprocessw#parameters > > Bug: #37751 > Change-Id: Ia3486d9a8c6b38c526c651dd6a801e0b8dad8655 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112267 > Reviewed-by: Siva Annamalai <asiva@google.com> > Commit-Queue: Zichang Guo <zichangguo@google.com> TBR=zra@google.com,asiva@google.com,zichangguo@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: #37751 Change-Id: Ifae15d01b96d91ee88b24469e08ecb4ecc97a832 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112921 Reviewed-by: Zichang Guo <zichangguo@google.com> Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Zichang Guo <zichangguo@google.com>
diff --git a/runtime/bin/process_patch.dart b/runtime/bin/process_patch.dart
@@ -233,14 +233,7 @@ class _ProcessImpl extends _ProcessImplNativeWrapper implements Process {
     if (path is! String) {
       throw new ArgumentError("Path is not a String: $path");
     }
-
-    if (Platform.isWindows) {
-      // Escape paths that may contain spaces
-      // Bug: https://github.com/dart-lang/sdk/issues/37751
-      _path = _windowsArgumentEscape(path);
-    } else {
-      _path = path;
-    }
+    _path = path;
 
     if (arguments is! List) {
       throw new ArgumentError("Arguments is not a List: $arguments");
