[vm/fuzzer] Add ia32,arm32,arm64 modes to KBC

aartbik · commit-bot@chromium.org · commit 4080ea787dde · 2019-08-08T22:11:32.000Z
Rationale: Bytecode implementation is ready for some more exhaustive testing. Fuzz on! Change-Id: I648cc447ebb830bda56ae6659ca5bc65d13c76b6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112405 Reviewed-by: Ben Konyi <bkonyi@google.com> Commit-Queue: Aart Bik <ajcbik@google.com>
diff --git a/runtime/tools/dartfuzz/README.md b/runtime/tools/dartfuzz/README.md
@@ -50,26 +50,19 @@ where
     --dart-top        : sets DART_TOP explicitly through command line
     --mode1           : m1
     --mode2           : m2, and values one of
-        jit-[debug-]ia32    = Dart JIT (ia32)
-        jit-[debug-]x64     = Dart JIT (x64)
-        jit-[debug-]arm32   = Dart JIT (simarm)
-        jit-[debug-]arm64   = Dart JIT (simarm64)
-        jit-[debug-]dbc32   = Dart JIT (simdbc)
-        jit-[debug-]dbc64   = Dart JIT (simdbc64)
-        aot-[debug-]x64     = Dart AOT (x64)
-        aot-[debug-]arm32   = Dart AOT (simarm)
-        aot-[debug-]arm64   = Dart AOT (simarm64)
-        kbc-int-[debug-]x64 = Dart KBC (interpreted bytecode)
-        kbc-mix-[debug-]x64 = Dart KBC (mixed-mode bytecode)
-        kbc-cmp-[debug-]x64 = Dart KBC (compiled bytecode)
-        djs-x64             = dart2js + Node.JS
+        jit-[debug-][ia32|x64|arm32|arm64|dbc32|dbc64]   = Dart JIT
+        aot-[debug-][x64|arm32|arm64]                    = Dart AOT
+        kbc-[int|mix|cmp]-[debug-][ia32|x64|arm32|arm64] = Dart KBC
+                                                           (interpreted/
+                                                            mixed-mode/
+                                                            compiled bytecode)
+        djs-x64                                          = dart2js + Node.JS
     --[no-]rerun       : re-run a testcase if there is only a divergence in
-                         the return codes (not in the output);
+                         the return codes outside the range [-255,+255];
                          if the second run produces no divergence the previous
                          one will be ignored (true by default)
 
-
-If no modes are given, a random JIT and/or AOT combination is used.
+If no modes are given, a random combination is used.
 
 This fuzz testing tool must have access to the top of a Dart SDK
 development tree (DART_TOP) in which all proper binaries have been
diff --git a/runtime/tools/dartfuzz/dartfuzz_test.dart b/runtime/tools/dartfuzz/dartfuzz_test.dart
@@ -63,11 +63,9 @@ abstract class TestRunner {
       prefix += '-CMP';
       extraFlags += ['--use-bytecode-compiler'];
     }
-    // Every once in a while, go directly from source for kbc-*-x64.
+    // Every once in a while, go directly from source for kbc.
     bool kbcSrc = false;
-    if (mode.startsWith('kbc') &&
-        mode.endsWith('x64') &&
-        rand.nextInt(4) == 0) {
+    if (mode.startsWith('kbc') && rand.nextInt(4) == 0) {
       prefix += '-SRC';
       kbcSrc = true;
     }
@@ -593,12 +591,30 @@ class DartFuzzTestSession {
     'jit-arm64',
     'aot-debug-x64',
     'aot-x64',
+    'kbc-int-debug-ia32',
+    'kbc-cmp-debug-ia32',
+    'kbc-mix-debug-ia32',
     'kbc-int-debug-x64',
     'kbc-cmp-debug-x64',
     'kbc-mix-debug-x64',
+    'kbc-int-debug-arm32',
+    'kbc-cmp-debug-arm32',
+    'kbc-mix-debug-arm32',
+    'kbc-int-debug-arm64',
+    'kbc-cmp-debug-arm64',
+    'kbc-mix-debug-arm64',
+    'kbc-int-ia32',
+    'kbc-cmp-ia32',
+    'kbc-mix-ia32',
     'kbc-int-x64',
     'kbc-cmp-x64',
     'kbc-mix-x64',
+    'kbc-int-arm32',
+    'kbc-cmp-arm32',
+    'kbc-mix-arm32',
+    'kbc-int-arm64',
+    'kbc-cmp-arm64',
+    'kbc-mix-arm64',
   ];
 
   // Modes not used on cluster runs because they have outstanding issues.
