[gardening] Fix non-web-integer in corelib_2/num_parse_test

rakudrama · commit-bot@chromium.org · commit 2c26ece3cfdc · 2019-07-11T17:53:53.000Z
Change-Id: Ie89d5065cc6a3c3a05f8bf52c57b8f082a830b2c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108760 Reviewed-by: Lasse R.H. Nielsen <lrn@google.com> Commit-Queue: Stephen Adams <sra@google.com>
diff --git a/tests/corelib_2/corelib_2.status b/tests/corelib_2/corelib_2.status
@@ -39,8 +39,6 @@ integer_to_string_test/01: RuntimeError
 integer_to_string_test/01: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
 iterable_return_type_test/02: RuntimeError # Dart2js does not support Uint64*.
 list_unmodifiable_test: Pass, RuntimeError # Issue 28712
-num_parse_test/01: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
-num_parse_test/none: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
 
 [ $compiler != dartdevc ]
 error_stack_trace_test/static: MissingCompileTimeError
@@ -316,8 +314,6 @@ list_concurrent_modify_test: RuntimeError # DDC uses ES6 array iterators so it d
 list_removeat_test: RuntimeError # Issue 29921
 main_test: RuntimeError # Issue 29921
 nan_infinity_test/01: RuntimeError # Issue 29921
-num_parse_test/01: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
-num_parse_test/none: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
 regexp/alternative-length-miscalculation_test: RuntimeError # Issue 29921
 regexp/ascii-regexp-subject_test: RuntimeError # Issue 29921
 regexp/bol-with-multiline_test: RuntimeError # Issue 29921
diff --git a/tests/corelib_2/num_parse_test.dart b/tests/corelib_2/num_parse_test.dart
@@ -135,7 +135,9 @@ void main() {
   testIntAround(0x10000000000000); // 2^52
   testIntAround(0x20000000000000); // 2^53
   testIntAround(0x40000000000000); // 2^54
-  testIntAround(0x7ffffffffffffffe); // 2^63
+  // 0x7ffffffffffffffe on int-is-64-bit implementations, rounded up on
+  // int-is-double implementations.
+  testIntAround(0x7ffffffffffff000 + 0xffe); // 2^63
 
   testDouble(0.0);
   testDouble(5e-324);
