Skip to content

Commit 2659262

Browse files
[nnbd_migration] Remove TODO now that do-while is more supported
Change-Id: Idfaa290290954d6b4bdf131a26f760b85c7e4312 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112649 Reviewed-by: Paul Berry <[email protected]> Commit-Queue: Mike Fairhurst <[email protected]>
1 parent 721ff35 commit 2659262

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

pkg/nnbd_migration/test/edge_builder_test.dart

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2568,9 +2568,8 @@ void test(bool b, C c) {
25682568
}
25692569
''');
25702570

2571-
// TODO(mfairhurst): enable this check
2572-
//assertNullCheck(checkExpression('b/*check*/'),
2573-
// assertEdge(decoratedTypeAnnotation('bool b').node, never, hard: false));
2571+
assertNullCheck(checkExpression('b/*check*/'),
2572+
assertEdge(decoratedTypeAnnotation('bool b').node, never, hard: false));
25742573
assertNullCheck(checkExpression('c.m'),
25752574
assertEdge(decoratedTypeAnnotation('C c').node, never, hard: false));
25762575
}
@@ -2591,9 +2590,8 @@ void test(bool b, C c1, C c2) {
25912590
}
25922591
''');
25932592

2594-
// TODO(mfairhurst): enable this check
2595-
//assertNullCheck(checkExpression('b/*check*/'),
2596-
// assertEdge(decoratedTypeAnnotation('bool b').node, never, hard: true));
2593+
assertNullCheck(checkExpression('b/*check*/'),
2594+
assertEdge(decoratedTypeAnnotation('bool b').node, never, hard: true));
25972595
assertNullCheck(checkExpression('c1.m'),
25982596
assertEdge(decoratedTypeAnnotation('C c1').node, never, hard: true));
25992597
assertNullCheck(checkExpression('c2.m'),

0 commit comments

Comments
 (0)