Skip to content

Commit 1f02c10

Browse files
rakudramacommit-bot@chromium.org
authored andcommitted
Update language_2/const_map4_test for type inference
Change-Id: Id81d974b0889e7c469ed40c85955f9b18265c634 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107927 Auto-Submit: Stephen Adams <[email protected]> Reviewed-by: Leaf Petersen <[email protected]> Commit-Queue: Stephen Adams <[email protected]>
1 parent 99ed487 commit 1f02c10

4 files changed

Lines changed: 5 additions & 6 deletions

File tree

‎tests/language_2/const_map4_test.dart‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,15 @@ main() {
1313
b = const {1: 'a', 2: 'b', 3: 'c'};
1414
Expect.equals(true, a == b);
1515

16+
a = const <int, String>{1: 'a', 2: 'b', 3: 'c'};
17+
b = const {1: 'a', 2: 'b', 3: 'c'};
18+
Expect.equals(true, a == b);
19+
1620
a = const <num, String>{1: 'a', 2: 'b', 3: 'c'};
1721
b = const {1: 'a', 2: 'b', 3: 'c'};
1822
Expect.equals(false, a == b);
1923

2024
a = const <dynamic, dynamic>{1: 'a', 2: 'b', 3: 'c'};
2125
b = const {1: 'a', 2: 'b', 3: 'c'};
22-
Expect.equals(true, a == b);
26+
Expect.equals(false, a == b);
2327
}

‎tests/language_2/language_2_dart2js.status‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ const_evaluation_test/01: RuntimeError
3939
const_list_test: RuntimeError
4040
const_map2_test/00: MissingCompileTimeError
4141
const_map3_test/00: MissingCompileTimeError
42-
const_map4_test: RuntimeError
4342
const_switch_test/02: RuntimeError, OK # constant identity based on JS constants
4443
const_switch_test/04: RuntimeError, OK # constant identity based on JS constants
4544
constructor12_test: RuntimeError

‎tests/language_2/language_2_dartdevc.status‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,6 @@ compile_time_constant_e_test: RuntimeError # Issue 30876; Expect.identical(expec
306306
config_import_corelib_test: CompileTimeError
307307
const_evaluation_test/01: RuntimeError # dart:mirrors not supported in DDC
308308
const_list_test: RuntimeError # Expect.equals(expected: <false>, actual: <true>) fails.
309-
const_map4_test: RuntimeError # Expect.equals(expected: <true>, actual: <false>) fails.
310309
const_switch_test/02: RuntimeError # Issue 29920; Expect.equals(expected: <0>, actual: <0.0>) fails.
311310
const_switch_test/04: RuntimeError # Ints and doubles are unified.; Expect.equals(expected: <1>, actual: <1.0>) fails.
312311
constructor12_test: RuntimeError # Issue 29920; ReferenceError: JSArrayOfT is not defined

‎tests/language_2/language_2_kernel.status‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ config_import_corelib_test: CompileTimeError
3333
config_import_test: RuntimeError
3434
const_list_test: RuntimeError
3535
const_locals_test: RuntimeError
36-
const_map4_test: RuntimeError
3736
const_nested_test: RuntimeError
3837
const_string_test: RuntimeError
3938
constructor12_test: RuntimeError
@@ -590,7 +589,6 @@ config_import_corelib_test: CompileTimeError # Issue 31533
590589
config_import_test: RuntimeError # KernelVM bug: Configurable imports.
591590
const_evaluation_test: SkipByDesign
592591
const_list_test: RuntimeError
593-
const_map4_test: RuntimeError
594592
constructor12_test: RuntimeError
595593
constructor3_test: Fail, OK, Pass
596594
ct_const2_test: Skip # Incompatible flag: --compile_all
@@ -915,7 +913,6 @@ config_import_test: RuntimeError # KernelVM bug: Configurable imports.
915913
const_dynamic_type_literal_test/02: RuntimeError # KernelVM bug: Constant map duplicated key.
916914
const_list_test: RuntimeError
917915
const_locals_test: RuntimeError
918-
const_map4_test: RuntimeError
919916
const_nested_test: RuntimeError # KernelVM bug: Constant evaluation.
920917
const_string_test: RuntimeError
921918
constructor12_test: RuntimeError

0 commit comments

Comments
 (0)