[nnbd_migration] Origin for inferred instance creation bounds

MichaelRFairhurst · commit-bot@chromium.org · commit 1d1f3a5049f9 · 2020-02-28T23:26:22.000Z
Change-Id: Ice51e241833e4eb70f7b41accc3908717ca8bd72 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137659 Reviewed-by: Paul Berry <paulberry@google.com>
diff --git a/pkg/analysis_server/test/src/edit/nnbd_migration/info_builder_test.dart b/pkg/analysis_server/test/src/edit/nnbd_migration/info_builder_test.dart
@@ -320,6 +320,31 @@ void main() {
         details: ['This type parameter is instantiated with a nullable type']);
   }
 
+  Future<void> test_bound_instantiation_implicit() async {
+    UnitInfo unit = await buildInfoForSingleTestFile('''
+class C<T extends Object> {
+  C(T/*!*/ t);
+}
+
+void main() {
+  C(null);
+}
+''', migratedContent: '''
+class C<T extends Object?> {
+  C(T/*!*/ t);
+}
+
+void main() {
+  C(null);
+}
+''');
+    List<RegionInfo> regions = unit.regions;
+    expect(regions, hasLength(2));
+    assertRegion(region: regions[0], offset: 24, details: [
+      'This type parameter is instantiated with an inferred nullable type'
+    ]);
+  }
+
   Future<void> test_bound_method_explicit() async {
     UnitInfo unit = await buildInfoForSingleTestFile('''
 f<T extends Object> {}
diff --git a/pkg/nnbd_migration/lib/src/edge_builder.dart b/pkg/nnbd_migration/lib/src/edge_builder.dart
@@ -909,6 +909,8 @@ class EdgeBuilder extends GeneralizingAstVisitor<DecoratedType>
             .toList();
         instrumentation?.implicitTypeArguments(
             source, node, decoratedTypeArguments);
+        parameterEdgeOrigins = List.filled(typeArgumentTypes.length,
+            InferredTypeParameterInstantiationOrigin(source, node));
       } else {
         // Note: this could happen if the code being migrated has errors.
         typeArgumentTypes = const [];
