Skip to content

Commit 182a59c

Browse files
a-sivaa-siva
committed
Skip all tests that use spawnUri when running in simulator mode as it makes no sense to run the CFE on the simulator.
Change-Id: Ie3457e67fe4ddb3170bf4654effdc5b21dff2450 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107942 Reviewed-by: Alexander Aprelev <[email protected]>
1 parent 1427a21 commit 182a59c

2 files changed

Lines changed: 15 additions & 7 deletions

File tree

‎runtime/tests/vm/vm.status‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,6 @@ cc/CreateMirrorSystem: SkipByDesign # Imports dart:mirrors
5858
cc/StandaloneSnapshotSize: SkipByDesign # Imports dart:mirrors
5959
dart/redirection_type_shuffling_test: SkipByDesign # Imports dart:mirrors
6060

61-
[ $runtime == dart_precompiled ]
62-
dart/data_uri_spawn_test: SkipByDesign # Isolate.spawnUri
63-
dart/issue32950_test: SkipByDesign # uses spawnUri.
64-
6561
[ $system == fuchsia ]
6662
cc/CorelibIsolateStartup: Skip # OOM crash can bring down the OS.
6763
cc/Read: Fail # TODO(zra): Investigate, ../../dart/runtime/bin/file_test.cc: 34: error: expected: !file->WriteByte(1)
@@ -110,7 +106,6 @@ dart/appjit*: SkipByDesign # Test needs to run from source
110106
dart/kernel_determinism_test: SkipByDesign # Test needs to run from source
111107

112108
[ $compiler == dartkp && ($runtime == dart_precompiled || $runtime == vm) ]
113-
dart/issue32950_test: SkipByDesign # uses spawnUri.
114109
dart/redirection_type_shuffling_test: SkipByDesign # Includes dart:mirrors.
115110
dart/spawn_shutdown_test: SkipSlow
116111

@@ -262,6 +257,14 @@ dart/entrypoints/aot/*: SkipByDesign # Only supported in the Dart 2 JIT and AOT,
262257
[ $mode == debug || $runtime != dart_precompiled || $system == android ]
263258
dart/use_bare_instructions_flag_test: SkipByDesign # This test is for VM AOT only and is quite slow (so we don't run it in debug mode).
264259

260+
# It makes no sense to run any test that uses spawnURI under the simulator
261+
# as that would involve running CFE (the front end) in simulator mode
262+
# to compile the URI file specified in spawnURI code.
263+
# These Isolate tests that use spawnURI are hence skipped on purpose.
264+
[ $runtime == dart_precompiled || $runtime == vm && ($arch == simarm || $arch == simarm64 || $arch == simdbc64) ]
265+
dart/data_uri_spawn_test: SkipByDesign # Isolate.spawnUri
266+
dart/issue32950_test: SkipByDesign # uses spawnUri.
267+
265268
[ $runtime != dart_precompiled || $system == android ]
266269
dart/bare_instructions_trampolines_test: SkipByDesign # This test is for VM AOT only (android fails due to listing interfaces).
267270

‎tests/co19_2/co19_2-kernel.status‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,6 @@ LibTest/io/ZLibDecoder/fuse_A01_t01: RuntimeError
5050
LibTest/io/exit/exit_A01_t01: RuntimeError
5151
LibTest/io/exit/exit_A02_t01: RuntimeError
5252
LibTest/io/exitCode/exitCode_A01_t01: RuntimeError
53-
LibTest/isolate/Isolate/spawnUri_A01_t02: RuntimeError
54-
LibTest/isolate/Isolate/spawnUri_A05_t05: RuntimeError
5553
LibTest/isolate/ReceivePort/lastWhere_A01_t01: RuntimeError
5654

5755
[ $compiler == fasta ]
@@ -1432,3 +1430,10 @@ LibTest/math/MutableRectangle/height_A03_t02: RuntimeError
14321430
LibTest/math/MutableRectangle/width_A03_t02: RuntimeError
14331431
LibTest/math/Rectangle/Rectangle_A03_t04: RuntimeError
14341432
Utils/tests/Expect/throws_A01_t04: RuntimeError
1433+
1434+
# It makes no sense to run any test that uses spawnURI under the simulator
1435+
# as that would involve running CFE (the front end) in simulator mode
1436+
# to compile the URI file specified in spawnURI code.
1437+
# These Isolate tests that use spawnURI are hence skipped on purpose.
1438+
[ $runtime == dart_precompiled || $runtime == vm && ($arch == simarm || $arch == simarm64 || $arch == simdbc64) ]
1439+
LibTest/isolate/Isolate/spawnUri*: Skip

0 commit comments

Comments
 (0)