Skip to content

Commit 17aa00c

Browse files
athomascommit-bot@chromium.org
authored andcommitted
[co19] Skip LayoutTests and WebPlatfromTest
These tests test the browsers more than Dart. They are outdated, flaky, and, therefore, often ignored by the teams working web technologies. This CL Skips them pending their removal in an upcoming co19 roll. Change-Id: I0646fbcbd06ea9ea4d74ec07149bfe3b8011a57d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112344 Auto-Submit: Alexander Thomas <[email protected]> Reviewed-by: Vijay Menon <[email protected]> Commit-Queue: Alexander Thomas <[email protected]>
1 parent 4d30d9c commit 17aa00c

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

tests/co19_2/co19_2-dart2js.status

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
# for details. All rights reserved. Use of this source code is governed by a
33
# BSD-style license that can be found in the LICENSE file.
44

5-
[ $builder_tag != run_webgl_tests && $compiler == dart2js ]
6-
LayoutTests/fast/canvas/webgl*: Skip # Only run WebGL on special builders, issue 29961
7-
85
[ $compiler == dart2js && $runtime == d8 ]
96
LayoutTests/*: SkipByDesign # d8 is not a browser
107
LibTest/html/*: SkipByDesign # d8 is not a browser
@@ -33,8 +30,10 @@ LibTest/core/List/List_class_A01_t06: SkipSlow # slow babeljs transformation
3330

3431
[ $compiler == dart2js || $compiler == dartdevc || $compiler == dartdevk ]
3532
Language/Expressions/Spawning_an_Isolate/new_isolate_t01: SkipByDesign
33+
LayoutTests/*: Skip # These tests are going to be removed.
3634
LibTest/io/*: SkipByDesign # dart:io not supported.
3735
LibTest/isolate/*: SkipByDesign # dart:isolate not supported.
36+
WebPlatformTest/*: Skip # These tests are going to be removed.
3837

3938
[ $compiler == dartdevc || $compiler == dartdevk ]
4039
Language/Classes/Constructors/Generative_Constructors/formal_parameter_t07: Skip # Times out

0 commit comments

Comments
 (0)