Reland "[dartdevc] Immediately throw when encountering an unevaluated constant"

nshahan · commit-bot@chromium.org · commit 11f5b34f07b6 · 2019-07-23T23:18:15.000Z
This reverts commit 62674b9. Reason for revert: There is no reason we should ever encounter an unevaluated constant in DDK and doing so implies there is an error in the constant evaluation. We hope to find all such errors with this assertion. If this causes any more test failures, feel free to revert this again and create an issue so we can fix. A fix for the issue seen in the flutter-hhh bot has landed: flutter/engine#10069 Original change's description: > Revert "[dartdevc] Immediately throw when encountering an unevaluated constant" > > This reverts commit fd38424. > > Temporarily disabling this to get Flutter roll going. See > #37605 > > TBR=nshahan@google.com > > Change-Id: I44dbb1d4aaf8d5f9cc05f096d26cade93a364f4c > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110120 > Reviewed-by: Vijay Menon <vsm@google.com> > Commit-Queue: Vijay Menon <vsm@google.com> TBR=vsm@google.com,nshahan@google.com Change-Id: Ibcb719d3e6c0026b11a812bec853e158b338d51a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110185 Commit-Queue: Nicholas Shahan <nshahan@google.com> Reviewed-by: Nicholas Shahan <nshahan@google.com> Reviewed-by: Vijay Menon <vsm@google.com>
diff --git a/pkg/dev_compiler/lib/src/kernel/compiler.dart b/pkg/dev_compiler/lib/src/kernel/compiler.dart
@@ -5376,7 +5376,7 @@ class ProgramCompiler extends Object
 
   @override
   js_ast.Expression visitUnevaluatedConstant(UnevaluatedConstant node) =>
-      _visitExpression(node.expression);
+      throw UnsupportedError('Encountered an unevaluated constant: $node');
 }
 
 bool _isInlineJSFunction(Statement body) {

Original file line number	Diff line number	Diff line change
`@@ -5376,7 +5376,7 @@ class ProgramCompiler extends Object`
`5376`	`5376`
`5377`	`5377`	`@override`
`5378`	`5378`	`js_ast.Expression visitUnevaluatedConstant(UnevaluatedConstant node) =>`
`5379`		`- _visitExpression(node.expression);`
	`5379`	`+ throw UnsupportedError('Encountered an unevaluated constant: $node');`
`5380`	`5380`	`}`
`5381`	`5381`
`5382`	`5382`	`bool _isInlineJSFunction(Statement body) {`