Add tests to show that combinators work correctly with extensions

bwilkerson · commit-bot@chromium.org · commit 06d4cd328402 · 2019-08-07T22:19:15.000Z
Change-Id: Ibe72662d70ff776153814aec960a8409117f0196 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112266 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Phil Quitslund <pquitslund@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
diff --git a/pkg/analyzer/test/src/dart/resolution/extension_method_test.dart b/pkg/analyzer/test/src/dart/resolution/extension_method_test.dart
@@ -4,6 +4,7 @@
 
 import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/src/dart/analysis/driver.dart';
+import 'package:analyzer/src/error/codes.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:test/test.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
@@ -152,6 +153,42 @@ extension on C {}
     assertElement(extendedType, findElement.class_('C'));
     assertType(extendedType, 'C');
   }
+
+  test_visibility_hidden() async {
+    newFile('/test/lib/lib.dart', content: '''
+class C {}
+extension E on C {
+  int a = 1;
+}
+''');
+    await assertErrorsInCode('''
+import 'lib.dart' hide E;
+
+f(C c) {
+  c.a;
+}
+''', [
+      error(StaticTypeWarningCode.UNDEFINED_GETTER, 40, 1),
+    ]);
+  }
+
+  test_visibility_notShown() async {
+    newFile('/test/lib/lib.dart', content: '''
+class C {}
+extension E on C {
+  int a = 1;
+}
+''');
+    await assertErrorsInCode('''
+import 'lib.dart' show C;
+
+f(C c) {
+  c.a;
+}
+''', [
+      error(StaticTypeWarningCode.UNDEFINED_GETTER, 40, 1),
+    ]);
+  }
 }
 
 /// Tests that extension members can be correctly resolved when referenced
