Repository navigation
[jnigen] Fix race conditions in tests - #3767
Merged
Merged
Conversation
github-actions
Bot
added
type-infra
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3767 +/- ##
=======================================
Coverage 87.94% 87.94%
=======================================
Files 310 310
Lines 19848 19848
=======================================
Hits 17456 17456
Misses 2392 2392
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
goderbauer
force-pushed
the
jnigen-fix-test-races
branch
from
October 27, 2026 10:18
b7601ee to
452d90c
Compare
github-actions
Bot
removed
the
type-infra
liamappelbe
approved these changes
Oct 30, 2026
copybara-service Bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Nov 4, 2026
Revisions updated by `dart tools/rev_sdk_deps.dart native`. native (https://github.com/dart-lang/native/compare/e0ca7c6..b442038): b442038de Mon Nov 2 10:46:15 2026 -0800 Brian Quinlan [objective_c] support `scheduleInRunLoop:forMode:` (dart-lang/native#3763) 264318e75 Fri Oct 30 12:49:03 2026 -0700 Brian Quinlan [objective_c] fix `toNSInputStream` double copy (dart-lang/native#3762) 63f3e8641 Fri Oct 30 12:09:04 2026 -0700 Brian Quinlan [objective_c] avoid an extra copy in `toNSData` (dart-lang/native#3761) ad203b01d Fri Oct 30 11:48:15 2026 -0700 Brian Quinlan [objective_c] increase read chunk size (dart-lang/native#3760) fa112d95b Fri Oct 30 09:14:23 2026 -0700 Brian Quinlan [objective_c] Fix a `NSInputStream` hang (dart-lang/native#3751) 035f4ef38 Fri Oct 30 09:23:30 2026 +0100 Michael Goderbauer [jnigen] Fix race conditions in tests (dart-lang/native#3767) d58a8f514 Fri Oct 30 00:57:49 2026 -0400 Jhin Lee [code_assets] Preserve full Apple deployment versions (dart-lang/native#3742) Migrate `MacOSCodeConfig` in `pkg/dartdev/lib/src/native_assets.dart` from the deprecated `targetVersion` parameter to `deploymentVersion: AppleVersion(...)`. Change-Id: I2df469fc05bda2c1db051f43e803fe5145f7c246 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/573102 Auto-Submit: Nate Bosch <[email protected]> Reviewed-by: Nicholas Shahan <[email protected]> Reviewed-by: Ben Konyi <[email protected]> Commit-Queue: Ben Konyi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Antigravity fixed two test race conditions in package:jnigen that frequently occurred on CI for dart-lang/native#3766, dart-lang/native#3765, and dart-lang/native#3756:
mvn packageandjavacoutput directories acrossbindingsTestSetup,descriptor_test,kotlin_test, andsimple_package_testso concurrent test suites do not overwritekotlin_test-jar-with-dependencies.jaror.classfiles while other tests are reading them, and evaluategetConfiglazily insidegenerateAndCompareso-x bindingstest runs do not trigger unnecessary builds during test registration.argbefore sending'callback_executed'and defercallbackPort.send('callback_executed')viaTimer.runin_jnigenConsumerIsolateEntryso botharg?.release()and the generated binding's$i.args?.release()(which runs after_$invokeMethodreturns) complete before the main isolate kills the consumer isolate withIsolate.immediate.