Repository navigation
[objective_c] avoid an extra copy in toNSData - #3761
Merged
Merged
Conversation
`toNSData` copied the list into a temporary buffer and then copied that buffer into a new `NSData`. Now the `NSData` takes ownership of the buffer (`initWithBytesNoCopy:length:freeWhenDone:`), so the data is copied once. `toNSData` originally worked this way (dart-lang#1104), but was changed to copy twice in dart-lang#1100 because of crashes when the `NSData` was destroyed (dart-lang#1107). Those crashes were caused by FFIgen treating `dataWithBytesNoCopy:length:` as returning a retained object, because its name contains "Copy", so the `NSData` was over-released. FFIgen has followed the Objective-C method family rules since dart-lang#1463, and `initWithBytesNoCopy:length:freeWhenDone:` is in the `init` family, so it really does return a retained object. Adds tests that the list is copied, that the bytes stay valid while the `NSData` is alive, and that they are freed when it is deallocated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3761 +/- ##
=======================================
Coverage 85.84% 85.84%
=======================================
Files 322 322
Lines 20876 20877 +1
=======================================
+ Hits 17921 17922 +1
Misses 2955 2955
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
liamappelbe
approved these changes
Oct 30, 2026
copybara-service Bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Nov 4, 2026
Revisions updated by `dart tools/rev_sdk_deps.dart native`. native (https://github.com/dart-lang/native/compare/e0ca7c6..b442038): b442038de Mon Nov 2 10:46:15 2026 -0800 Brian Quinlan [objective_c] support `scheduleInRunLoop:forMode:` (dart-lang/native#3763) 264318e75 Fri Oct 30 12:49:03 2026 -0700 Brian Quinlan [objective_c] fix `toNSInputStream` double copy (dart-lang/native#3762) 63f3e8641 Fri Oct 30 12:09:04 2026 -0700 Brian Quinlan [objective_c] avoid an extra copy in `toNSData` (dart-lang/native#3761) ad203b01d Fri Oct 30 11:48:15 2026 -0700 Brian Quinlan [objective_c] increase read chunk size (dart-lang/native#3760) fa112d95b Fri Oct 30 09:14:23 2026 -0700 Brian Quinlan [objective_c] Fix a `NSInputStream` hang (dart-lang/native#3751) 035f4ef38 Fri Oct 30 09:23:30 2026 +0100 Michael Goderbauer [jnigen] Fix race conditions in tests (dart-lang/native#3767) d58a8f514 Fri Oct 30 00:57:49 2026 -0400 Jhin Lee [code_assets] Preserve full Apple deployment versions (dart-lang/native#3742) Migrate `MacOSCodeConfig` in `pkg/dartdev/lib/src/native_assets.dart` from the deprecated `targetVersion` parameter to `deploymentVersion: AppleVersion(...)`. Change-Id: I2df469fc05bda2c1db051f43e803fe5145f7c246 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/573102 Auto-Submit: Nate Bosch <[email protected]> Reviewed-by: Nicholas Shahan <[email protected]> Reviewed-by: Ben Konyi <[email protected]> Commit-Queue: Ben Konyi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid an extra copy in
toNSDataPR Checklist
dart tool/ci.dart --alllocally and resolved all issues identified. This ensures the PR is formatted, has no lint errors, and ran all code generators. This applies to the packages part of the toplevelpubspec.yamlworkspace.CHANGELOG.mdfor the relevant packages. (Not needed for small changes such as doc typos).