Repository navigation
[infra] Remove double space from copyright notice - #3682
Closed
liamappelbe wants to merge 1 commit into
Closed
liamappelbe wants to merge 1 commit into
liamappelbe wants to merge 1 commit into
Conversation
github-actions
Bot
added
type-infra
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3682 +/- ##
=======================================
Coverage 88.06% 88.06%
=======================================
Files 305 305
Lines 19410 19410
=======================================
Hits 17094 17094
Misses 2316 2316
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Collaborator
|
The Dart SDK has more double space than single space 🤔 500 vs 1300 |
Contributor
Author
|
I don't feel strongly either way. It's easy enough to make our regexes recognise both. |
Collaborator
|
Yeah, lets do that then. If someone ever wants to go through all Dart repos and clean it up they can do that. But it feels weird to clean it up to a standard here if all the other Dart repos don't agree. 🤷 But I don't feel strong about it, if you want to pick the one or two spaces version for this repo, thats fine too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like a typo that spread throughout the monorepo.