Repository navigation
[jnigen] Relax binding verification test - #3627
Merged
liamappelbe merged 2 commits intoSep 11, 2026
Merged
Conversation
Contributor
|
Looks good. Can you test it works by doing a minor jnigen version bump? I think you might have to do the same fix in |
github-actions
Bot
added
the
type-infra
Contributor
Author
|
Tested with a minor jnigen version bump; the jnigen and jni_flutter checks now pass with version-only changes ignored, while jni doesn't require the same fix since its generated core_bindings.dart isn't included in the CI diff check. |
liamappelbe
approved these changes
Sep 11, 2026
copybara-service Bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Sep 11, 2026
Revisions updated by `dart tools/rev_sdk_deps.dart`. core (https://github.com/dart-lang/core/compare/7e8caaf..51cf766): 51cf7664 Thu Sep 10 17:49:25 2026 -0700 Kevin Moore test(crypto): add C2SP/Wycheproof test vectors for HMAC (dart-lang/core#993) native (https://github.com/dart-lang/native/compare/84d7eda..f2b4942): f2b4942cc Fri Sep 11 07:59:55 2026 +0530 Sivapriya [jnigen] Relax binding verification test (dart-lang/native#3627) protobuf (https://github.com/dart-lang/protobuf/compare/cde8e28..a73edc9): a73edc9 Fri Sep 11 12:54:45 2026 +0100 Martin Kustermann Remove legacy interop use (conditional import on dart.library.html) (google/protobuf.dart#1102) webdriver (https://github.com/google/webdriver.dart/compare/9b2e87d..8e5c611): 8e5c611 Fri Sep 11 01:32:05 2026 -0400 Nate Biggs Refactor matchState initialization to use untyped literal (google/webdriver.dart#349) TAG=agy CONV=688fe3c8-47b5-4273-96f1-b13470d355b6 [email protected] Change-Id: I3c2cb3870ccc229206da7d27a3b8ece7a1492842 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/548981 Reviewed-by: Brian Quinlan <[email protected]> Commit-Queue: Nate Bosch <[email protected]>
5 of 6 tasks
3 of 6 tasks
Hassnaa9
pushed a commit
to Hassnaa9/native
that referenced
this pull request
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ignores the generated JNIGEN version header when comparing generated bindings with reference bindings. This prevents version bumps from requiring otherwise unchanged bindings to be regenerated.
Related Issues
Fixes #3624
PR Checklist
dart tool/ci.dart --alllocally and resolved all issues identified. This ensures the PR is formatted, has no lint errors, and ran all code generators. This applies to the packages part of the toplevelpubspec.yamlworkspace.CHANGELOG.mdfor the relevant packages. (Not needed for small changes such as doc typos).