Skip to content

[native_toolchain_c] Fix CI try 3 - #3437

Merged
dcharkes merged 1 commit into
mainfrom
ntc-try-3
Jun 26, 2026
Merged

dcharkes merged 1 commit into
mainfrom
ntc-try-3

Conversation

@dcharkes

@dcharkes dcharkes commented Jun 26, 2026 •

Copy link
Copy Markdown
Collaborator

I've now installed xcode 26.5 with clang 21.0.0 locally.

I don't know why the bot on the PR passes but then fails when merged into main. Gemini suspects GitHub provisions different machine types for macos-latest. (Edit: apparently we were skipping #3438. But that doesn't explain why we would skip on the PR and not on the main branch...)

Adding S should prevent Apple's ranlib trying to add a Mach-O symbol table to the ELF file.

@github-actions

github-actions Bot commented Jun 26, 2026 •

Copy link
Copy Markdown

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
native_toolchain_c None 0.19.1 0.19.2 0.19.1 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@github-actions

Copy link
Copy Markdown

Package publishing

If you have publishing permissions, you can use the links below to publish the changes after merging this PR.

Package Version Status Publish tag (post-merge)
package:code_assets 1.2.1 already published at pub.dev
package:data_assets 0.20.0 already published at pub.dev
package:ffi 2.2.0 already published at pub.dev
package:hooks 2.0.2 already published at pub.dev
package:hooks_runner 1.5.1-wip WIP (no publish necessary)
package:jni_flutter 1.0.1 already published at pub.dev
package:native_toolchain_c 0.19.2 ready to publish native_toolchain_c-v0.19.2
package:record_use 0.6.1-wip WIP (no publish necessary)
package:swift2objc 0.2.0 already published at pub.dev
package:swiftgen 0.1.3-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@dcharkes
dcharkes marked this pull request as ready for review June 26, 2026 09:41
@dcharkes

Copy link
Copy Markdown
Collaborator Author

Third time is the charm @goderbauer 🙃

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcharkes
dcharkes merged commit 170d055 into main Jun 26, 2026
32 checks passed
@dcharkes
dcharkes deleted the ntc-try-3 branch June 26, 2026 11:27
mosuem added a commit that referenced this pull request Oct 9, 2026
Archives built on macOS for Linux and Android were created with `rcS`, that
is without a symbol table, because Apple's ranlib can't index ELF objects
(#3437). The NDK's and LLVM's ar can, and the symbol table is what
withSymbolsDefinedIn reads, so without it the Android cross-compilation
tests on macOS asked the linker for the undefined symbol again. Omit the
symbol table only when the archiver is Apple's ar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants