Skip to content

[json_syntax_generator] Support string regex in map keys - #2443

Merged
auto-submit[bot] merged 1 commit into
mainfrom
json-keys-regex
Jul 24, 2025
Merged

[json_syntax_generator] Support string regex in map keys#2443
auto-submit[bot] merged 1 commit into
mainfrom
json-keys-regex

Conversation

@dcharkes

@dcharkes dcharkes commented Jul 23, 2025

Copy link
Copy Markdown
Collaborator

Follow up of #2441.

This time adding support for regexes on the strings that are the keys of maps.

In order to avoid duplicating:

https://github.com/dart-lang/pub/blob/c3e50919d11896f014cb971e1776d00a0e2d18b3/lib/src/pubspec_parse.dart#L219-L226

Again, tested on the pubspec lock schema.

@github-actions

github-actions Bot commented Jul 23, 2025 •
edited
Loading

Copy link
Copy Markdown

PR Health

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️ 
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/native_doc_dartifier/lib/native_doc_dartifier.dart
pkgs/native_doc_dartifier/lib/src/native_doc_dartifier_base.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@dcharkes
dcharkes requested a review from goderbauer July 23, 2025 17:35
@dcharkes
dcharkes marked this pull request as ready for review July 23, 2025 17:35
goderbauer
goderbauer approved these changes Jul 24, 2025
View reviewed changes

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from json-syntax-regex to main July 24, 2025 10:33
@auto-submit
auto-submit Bot merged commit c23a9df into main Jul 24, 2025
@auto-submit
auto-submit Bot deleted the json-keys-regex branch July 24, 2025 10:48
@coveralls

coveralls commented Jul 24, 2025

Copy link
Copy Markdown

Coverage Status

coverage: 78.761% (-1.1%) from 79.847%
when pulling ed7067f on json-keys-regex
into ee47c28 on main.

@Dhairya-007 Dhairya-007 mentioned this pull request Nov 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

autosubmit package:code_assets package:data_assets package:hooks skip-breaking-check skip-changelog-check

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dcharkes @coveralls @goderbauer