Repository navigation
Windows dart ci - #23
Merged
Merged
Conversation
dcharkes
marked this pull request as ready for review
April 28, 2023 11:10
HosseinYousefi
approved these changes
Apr 28, 2023
HosseinYousefi
left a comment
HosseinYousefi
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks @dcharkes 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using MSVCs
cl.exean accompanying script sets the right environment variables, such asINCLUDE.In visual studio this is
vcvarsall.bat,vcvars64.bator a similar script, which can be discovered in a relative path fromcl.exe.However, on the Dart CI bots, we use a custom script which serves the same purpose.
See https://chromium.googlesource.com/chromium/tools/depot_tools/+/master/win_toolchain/.
We might as well make the script configurable in general, as maybe more compilers require setting the right environment variables. (Side note: on the Dart CI we also use a
clang.exewith this same environment variables script so that theclang.execan also find the Windows implementations forprintfetc.)Dart CL: https://dart-review.googlesource.com/c/sdk/+/298580