Repository navigation
[jnigen] adding the ability for the user to rename - #1946
Merged
HosseinYousefi merged 5 commits intoJan 31, 2025
Merged
Conversation
commit 92d2a8d Author: Marshelino Maged <[email protected]> Date: Mon Jan 27 21:17:25 2025 +0200 ability for the user to rename commit eec4f6e Author: Marshelino Maged <[email protected]> Date: Mon Jan 27 20:38:36 2025 +0200 edit test commit 24453db Author: Marshelino Maged <[email protected]> Date: Mon Jan 27 19:30:11 2025 +0200 enable user to rename
marshelino-maged
changed the title
HosseinYousefi
self-requested a review
January 29, 2025 11:31
HosseinYousefi
suggested changes
Jan 29, 2025
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
HosseinYousefi
approved these changes
Jan 31, 2025
HosseinYousefi
left a comment
HosseinYousefi
left a comment
Contributor
There was a problem hiding this comment.
LGTM with one very small change.
| log.fine('Class ${node.binaryName} is named ${node.finalName}'); | ||
|
|
||
| if (node.userDefinedName == null || | ||
| node.userDefinedName == node.finalName) { |
| void visit(Method node) { | ||
| final name = _preprocess(node.isConstructor ? 'new' : node.name); | ||
| final name = _preprocess( | ||
| node.isConstructor ? 'new' : node.userDefinedName ?? node.name); |
Contributor
There was a problem hiding this comment.
The user should technically be able to rename the constructors as well, I'm not sure that we currently support this in the dart_generator though. So let's fix that in another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.