You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
java.lang.Integer produces a different generated output on ubuntu-beta! #696
static final _parseInt1 = jniLookup<
+ ffi.NativeFunction<+ jni.JniResult Function(ffi.Pointer<ffi.Void>, ffi.Int32,+ ffi.Int32, ffi.Int32)>>("Integer__parseInt1")+ .asFunction<+ jni.JniResult Function(ffi.Pointer<ffi.Void>, int, int, int)>();++ /// from: static public int parseInt(java.lang.CharSequence charSequence, int i, int i1, int i2)+ static int parseInt1(jni.JObject charSequence, int i, int i1, int i2) =>+ _parseInt1(charSequence.reference, i, i1, i2).integer;++ static final _parseInt2 = jniLookup<
ffi.NativeFunction<
jni.JniResult Function(
- ffi.Pointer<ffi.Void>)>>("Integer__parseInt1")+ ffi.Pointer<ffi.Void>)>>("Integer__parseInt2")
.asFunction<jni.JniResult Function(ffi.Pointer<ffi.Void>)>();
/// from: static public int parseInt(java.lang.String string)
- static int parseInt1(jni.JString string) =>- _parseInt1(string.reference).integer;+ static int parseInt2(jni.JString string) =>+ _parseInt2(string.reference).integer;
Looks like our tests are not robust with Java adding new methods.
We should probably think of an approach that is less error prone. (We have the same issue with ffigen and libclang generating different bindings for different clang versions.)
IIRC, parseInt(charSequence, i, i1, i2) got added in Java 9, so this entire error is weird! Why does it not exist in the generated files to begin with? I'll need to look into this.
IIRC, parseInt(charSequence, i, i1, i2) got added in Java 9, so this entire error is weird! Why does it not exist in the generated files to begin with? I'll need to look into this.
Sounds like a classpath issue. It's possible Android JARs were in class_path of config and got picked up when reference bindings were generated, but not on CI.
Activity
dcharkes commentedon Dec 13, 2022
Looks like our tests are not robust with Java adding new methods.
We should probably think of an approach that is less error prone. (We have the same issue with ffigen and libclang generating different bindings for different clang versions.)
HosseinYousefi commentedon Dec 13, 2022
IIRC,
parseInt(charSequence, i, i1, i2)got added in Java 9, so this entire error is weird! Why does it not exist in the generated files to begin with? I'll need to look into this.mahesh-hegde commentedon Mar 23, 2023
Sounds like a classpath issue. It's possible Android JARs were in class_path of config and got picked up when reference bindings were generated, but not on CI.
mahesh-hegde commentedon Apr 13, 2023
What's the status of this?
HosseinYousefi commentedon Apr 20, 2023
Haven't been working on it. Need to see where the class paths are. Not a priority though.