You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've only found a single JniGenerator( with visitors:. I have low data on what real life use cases migrated to the visitor API look like.
Migrate all existing yaml files in the repo.
Migrate some existing use cases. (Cronet HTTP?) For visualization purposes.
I have little feedback on the visitor API as a result of this.
Example code style
(Our examples are public docs, what we intend our users to do, so I care about nits.)
pkgs/jnigen/example/in_app_java/tool/jnigen.dart
pkgs/jnigen/example/maven_libs/tool/generate_bindings.dart
pkgs/jnigen/example/maven_libs_groovy/tool/generate_bindings.dart
pkgs/jnigen/README.md
avoid splitting an await and async method call across multiple lines
awaitJniGenerator(
...
).generate();
->
final generator =JniGenerator(
...
);
await generator.generate();
Internal implementation nits
pkgs/jni/tool/generate_jni_bindings.dart
baseclassRenamerextendsVisitor {
Should this be final or private class? And/or should be be renamed _JniRenamer? e.g. for clarity that this renamer is and should not be imported anywhere. I know it's in tool/ but...
const removalPackageForSummaryTests ='com.github.dart_lang.jnigen.pkg2';
/// List of FQNs passed to summarizer for simple_package_test.final summarizerClassesSpec = [
...javaClasses.where((e) =>!e.startsWith('$removalPackageForSummaryTests.')),
removalPackageForSummaryTests,
];
inline in getSummaryGenerationConfig to avoid making it public?
Activity
liamappelbe commentedon Sep 2, 2026
Created dart-lang/http#1980. Can't land it until jnigen publishes