You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm really happy with our new API! I can only think of some final nits, no actual refactorings! 🥳
Migrate all existing yaml files in the repo.
class ExternalVersions is undocumented.
It's actually somewhat weird that these refer to specially recognized APIs from Apple. But it's probably fine.
If we ever introduce Dart conditional compilation, we'd split the generated code across different OS versions, and probably completely remove this config option. This config option only makes sense when there's no conditional compilation.
Enable public api docs lint.
linter:
rules:
- public_member_api_docs
Cpp mark the class getter and constructor param @experimental.
Code Style Nits
(These are our samples we direct users to from the docs. So I care about their style.)
This lint seems weird to me. There are tons of public API elements where what it does is obvious from the name. The lint is info level, so that's fine, but we're using fatal infos on CI. Also, not sure if it's misconfigured, but it even wants documentation for internal stuff (eg documenting all the sub_parsers). Those APIs are not exposed in the top level lib/ffigen.dart file. I get over 1000 issues found when I enable it.
Activity
liamappelbe commentedon Aug 31, 2026
This lint seems weird to me. There are tons of public API elements where what it does is obvious from the name. The lint is info level, so that's fine, but we're using fatal infos on CI. Also, not sure if it's misconfigured, but it even wants documentation for internal stuff (eg documenting all the
sub_parsers). Those APIs are not exposed in the top levellib/ffigen.dartfile. I get over 1000 issues found when I enable it.