Repository navigation
[intl] Use CLDR currency decimal/group separators in currency formats - #1128
leonsteinmann wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for currency-specific decimal and grouping separators in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces CURRENCY_DECIMAL_SEP and CURRENCY_GROUP_SEP to NumberSymbols, allowing currency formatting to use different separators than standard number formatting for specific locales like fr_CH and de_AT. The NumberFormat and NumberParserBase classes have been updated to utilize these new separators. A critical logic bug was identified in number_parser_base.dart, where a tautological OR condition (||) always evaluates to true, bypassing the validation check for space-based grouping separators; this should be corrected to an AND (&&) operator.
0ebd144 to
4d17e03
Compare
Fixes #1127
Adds optional currency-specific decimal and grouping separators to
NumberSymbols, falling back to the general number separators when the currency-specific values are absent. Currency formatting now uses the currency separators, including parsing and compact currency formatting.The generated
number_symbols_data.dartdata was hand-edited forde_ATandfr_CH, where the CLDR currency separators differ from the general number separators. This is a targeted data correction, not a broader CLDR refresh.Validation:
dart format lib testdart analyzedart test(1,563 passed, 5 skipped)