Repository navigation
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses compatibility issues with the Flutter beta channel by migrating the example application to the new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the intl dependency constraints across multiple packages to support version 0.20.0 and adds analyzer excludes to the Flutter examples. Feedback on the changes highlights an incorrect migration of the Flutter example to package:material_ui, which should be reverted back to package:flutter/material.dart. Additionally, the material_ui dependency should be removed from pubspec.yaml, the intl constraint in the example should be widened to match the other packages, and the changelog should be updated accordingly.
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| import 'package:flutter/material.dart'; | ||
| import 'package:material_ui/material_ui.dart'; |
There was a problem hiding this comment.
The import of package:material_ui/material_ui.dart is incorrect. package:flutter/material.dart is not deprecated in Flutter. This appears to be a hallucination by the AI agent. Please revert this import back to package:flutter/material.dart.
| import 'package:material_ui/material_ui.dart'; | |
| import 'package:flutter/material.dart'; |
| intl: ^0.20.0 | ||
| material_ui: ^1.0.0 |
| ## 0.3.0-wip | ||
|
|
||
| - Adapt to output data files to assets. | ||
| - Migrate `examples_flutter` to `package:material_ui` and allow `intl: ^0.20.0`. |
There was a problem hiding this comment.
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with Unused Dependencies ✔️
For details on how to fix these, see dependency_validator. This check can be disabled by tagging the PR with |
Note
This PR was generated by an AI coding agent (Jetski) on behalf of @mosuem.
Fixes the failing
package:messagesGitHub Actions check on Flutterbeta(>=3.47.0-0.0.pre), wherepackage:flutter/material.dartis deprecated in favor ofpackage:material_ui/material_ui.dart:package:flutter/material.dartwithpackage:material_ui/material_ui.dartinpkgs/messages/examples_flutter/my_application.intlconstraints to>=0.19.0 <0.21.0acrossmessages,messages_builder, andmessages_serializersomaterial_ui(intl: ^0.20.2) resolves cleanly alongside local path dependencies.analysis_options.yamlexclusions added byflutter pub geton Flutterbetaso the CIgit diff --exit-codestep stays clean.