Repository navigation
fix(http2): bound header size to 256 KiB - #1978
Closed
brianquinlan wants to merge 5 commits into
Closed
brianquinlan wants to merge 5 commits into
brianquinlan wants to merge 5 commits into
Conversation
Collaborator
Author
|
I think that #1958 makes this redundant. Will close this PR when that one is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add$O(N)$ defragmentation.
maxHeaderListSizesetting toClientSettingsandServerSettings(defaulting to 256 KiB), advertiseSETTINGS_MAX_HEADER_LIST_SIZE, enforce it during HPACK decoding, and limit CONTINUATION frame buffering withContribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.