Repository navigation
Conversation
- test on node in http and web_socket - add wasm testing to web_socket Closes #1126
github-actions
Bot
added
package:http
type-infra
PR HealthCoverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with Breaking changes ✔️
This check can be disabled by tagging the PR with
Unused Dependencies
|
| Package | Status |
|---|---|
| cupertino_http | ❗ Show IssuesThese packages are used outside lib/ but are not dev_dependencies: |
| http | ❗ Show IssuesThese packages may be unused, or you may be using assets from these packages: |
| web_socket | ❗ Show IssuesThese packages may be unused, or you may be using assets from these packages: |
For details on how to fix these, see dependency_validator.
This check can be disabled by tagging the PR with skip-unused-dependencies-check.
API leaks ⚠️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbol | Leaking sources |
|---|---|---|
| http | RequestCredentials | browser_client.dart::BrowserClient::new::requestCredentials browser_client.dart::RequestCredentials::omit browser_client.dart::RequestCredentials::sameOrigin browser_client.dart::RequestCredentials::include browser_client.dart::RequestCredentials::values |
This check can be disabled by tagging the PR with skip-leaking-check.
Member
Author
|
pkg:http - The changelog bit was related to a dev dependency |
Warning: Package resolution error when reading "analysis_options.yaml" file for "./pkgs/cupertino_http/ios_test/integration_test/combined_test.dart": Failed to resolve package URI "package:dart_flutter_team_lints/analysis_options.yaml" in include at "/Users/kevmoo/github/http/analysis_options.yaml".
github-actions
Bot
added
the
package:cupertino_http
brianquinlan
left a comment
brianquinlan
left a comment
Collaborator
There was a problem hiding this comment.
What do the build.yaml files do? Are we using build_runner now?
Member
Author
|
The |
brianquinlan
approved these changes
Oct 13, 2026
kevmoo
commented
Oct 13, 2026
| @@ -1,3 +1,7 @@ | |||
| ## 1.0.2-wip | |||
|
|
|||
| - Suppress false positive unused dependency warnings. | |||
copybara-service Bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Oct 15, 2026
Revisions updated by `dart tools/rev_sdk_deps.dart`. native is rolled separately in https://dart-review.googlesource.com/c/sdk/+/563524. http (https://github.com/dart-lang/http/compare/23f8574..7d7aae2): 7d7aae2 Mon Oct 12 20:39:25 2026 -0700 Kevin Moore Clean up dependencies and expand Node and Wasm test coverage (dart-lang/http#1903) ab986ad Mon Oct 12 18:59:24 2026 -0700 Kevin Moore fix(http_parser): fix chunked size overflow and MediaType.toString quoting (dart-lang/http#2001) cb8113b Mon Oct 12 17:35:26 2026 -0700 Kevin Moore docs(http2): move post-3.1.0 security entries to 3.2.0-wip (dart-lang/http#2022) test (https://github.com/dart-lang/test/compare/30acb69..9bf69a8): 9bf69a88 Tue Oct 13 14:33:18 2026 -0700 Nate Bosch Reject asynchronous matchers inside isNot and anyOf (dart-lang/test#2792) tools (https://github.com/dart-lang/tools/compare/2b54c71..350bde5): 350bde54f Tue Oct 13 08:22:26 2026 -0700 Kevin Moore chore(coverage): prepare for v1.16.0 release (dart-lang/tools#2643) a55965844 Tue Oct 13 13:29:52 2026 +0200 Sigurd Meldgaard [markdown] Fix quadratic parsing of consecutive link reference definitions (dart-lang/tools#2662) [email protected] TEST=ci Change-Id: I1065854cfbaf71ebb7a097d89f28902394a80c2e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/563365 Commit-Queue: Nate Bosch <[email protected]> Reviewed-by: Brian Quinlan <[email protected]>
kevmoo
added a commit
that referenced
this pull request
Oct 19, 2026
Remove the `build.yaml` internal CI configuration bullet added in #1903 from `pkgs/web_socket/CHANGELOG.md`, leaving the empty `1.0.2-wip` heading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1126