Repository navigation
Fix Connection reset by peer in protocol error tests - #1786
Merged
Merged
Conversation
``` SocketException: Connection reset by peer (OS Error: Connection reset by peer, errno = 54), address = localhost, port = 49332 dart:_http _HttpServer.listen package:web_socket_conformance_tests/src/peer_protocol_errors_server.dart 18:7 hybridMain ===== asynchronous gap =========================== dart:async _CustomZone.registerUnaryCallback package:web_socket_conformance_tests/src/peer_protocol_errors_server.dart 17:13 hybridMain package:web_socket_conformance_tests/src/peer_protocol_errors_server_vm.dart 10:3 startServer package:web_socket_conformance_tests/src/peer_protocol_errors_tests.dart 23:33 testPeerProtocolErrors.<fn>.<fn> ===== asynchronous gap =========================== package:stream_channel _GuaranteeSink.add /var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/flutter_tools.M74xpu/flutter_test_listener.SLapVu/listener.dart 53:22 main.<fn> ```
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
github-actions
Bot
added
the
type-infra
1 task done
liamappelbe
approved these changes
Jul 2, 2025
liamappelbe
left a comment
liamappelbe
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Does this need a changelog entry?
|
|
||
| }, (e, s) { | ||
| // dart:io sometimes asynchronously throws a `SocketException` with | ||
| //`errorCode` 54. |
Contributor
There was a problem hiding this comment.
uber nit: missing space after //.
Collaborator
Author
We don't release this package. |
copybara-service Bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jul 8, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. ai (https://github.com/dart-lang/ai/compare/64dfa7f..9b007b3): 9b007b3 2025-07-07 Jacob MacDonald Add failure reasons to tool call analytics events (dart-lang/ai#219) c8dc5da 2025-07-07 Jacob MacDonald don't bail early when running in multiple roots (dart-lang/ai#218) 2541b6c 2025-07-02 Kenzie Davisson Remove VS Code mcp instructions in favor of Dart-Code setting. (dart-lang/ai#206) 70daa1f 2025-07-02 Jacob MacDonald release dart_mcp 0.3.0 (dart-lang/ai#216) a252a46 2025-07-01 Jacob MacDonald add retry logic to try and make dtd_test less flaky (dart-lang/ai#214) 9e0b973 2025-07-01 Jacob MacDonald add a test that the arg parser library only depends on package:args (dart-lang/ai#213) http (https://github.com/dart-lang/http/compare/e70a41b..7d2d87e): 7d2d87e 2025-07-02 Brian Quinlan Fix `Connection reset by peer` in protocol error tests (dart-lang/http#1786) i18n (https://github.com/dart-lang/i18n/compare/ab90327..42c4932): 42c49328 2025-07-07 Googler No public description 87fd0156 2025-07-07 Michael Goderbauer [intl4x] Re-enable Windows (dart-lang/i18n#986) 912a7720 2025-07-07 Copybara-Service Merge pull request `#985` from dart-lang:fixConstantEvaluator 52f5beeb 2025-07-07 Moritz Small cleanups in intl4x (dart-lang/i18n#988) 6e8ef245 2025-07-07 Moritz squash sync_http (https://github.com/dart-lang/sync_http/compare/dc54465..c07f96f): c07f96f 2025-07-03 Kevin Moore Update to latest lints, required Dart 3.7 (google/sync_http.dart#55) tools (https://github.com/dart-lang/tools/compare/7bf22c9..6282b35): 6282b35e 2025-07-03 Lasse R.H. Nielsen [Markdown] Fix HTML comment parser. (dart-lang/tools#2121) web (https://github.com/dart-lang/web/compare/3e11172..fb8a149): fb8a149 2025-07-07 Nikechukwu Add Support for Configuration of Dart JS Interop Gen (dart-lang/web#386) Change-Id: Ib243021ed77846a8451f60fa320e5cf40e85aa27 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/439320 Commit-Queue: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes this exception, which is sometimes thrown when the client disconnects:
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.