Move publish check to health workflow and use individual package publishing workflows from `setup-dart` by mosuem · Pull Request #454 · dart-lang/ecosystem

mosuem · 2026-09-04T12:18:03Z

This PR refactors the ecosystem publishing architecture:

1. Integrate publish check into PR Health

Adds publish as a first-class health check in Health and health.yaml (Check.publish).
Uses Firehose.verify() to inspect modified packages, validate version bumps & changelog entries, and output the release readiness status table with the GitHub Release creation link.
Incorporates the publish status directly into the aggregated ## PR Health comment.

2. Replace monolithic `publish.yaml` with individual package workflows

Removes the shared .github/workflows/publish.yaml and .github/workflows/publish_internal.yaml.
Adds dedicated publishing workflows for each published package:
- .github/workflows/publish_firehose.yaml (triggers on firehose-v*)
- .github/workflows/publish_dart_flutter_team_lints.yaml (triggers on dart_flutter_team_lints-v*)
Each package workflow delegates directly to dart-lang/setup-dart/.github/workflows/publish.yml pinned to commit hash (f452aa90bb3c3726734faa9a86685617572bfeb0).
Provides full SLSA Build L3 provenance attestations via actions/attest@v4 with a clean security boundary between packaging and token-minting/signing.

3. Clean up obsolete firehose methods, executable, and workflows

Removes validate() and publish() methods from Firehose (verify() is retained for the health check).
Deletes the standalone bin/firehose.dart executable and its entry in pubspec.yaml.
Removes the defunct Publish:Internal trigger from post_summaries.yaml.

gemini-code-assist

Code Review

This pull request introduces a new publish health check to report package publishing readiness and release links. Feedback suggests passing ignored instead of ignoredPackages to the Firehose constructor to respect package-specific ignores, and conditionally omitting markdown table headers when there are no packages requiring publishing actions to avoid broken markdown rendering.

github-actions · 2026-09-04T12:26:29Z

PR Health

Publish ✔️

Package	Version	Status	Publish tag (post-merge)
package:firehose ⭐	0.13.2-wip	WIP (no publish necessary)

1 WIP (no publish necessary).

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

This check can be disabled by tagging the PR with skip-publish-check.

Changelog Entry ✔️

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check (for example, for non-user-visible changes when the package version is already at -wip).

Breaking changes ✔️

Package	Change	Current Version	New Version	Needed Version	Looking good?
dart_flutter_team_lints	None	3.5.2	3.6.0-wip	3.6.0-wip	✔️
firehose	Breaking	0.13.0	0.13.2-wip	0.13.2-wip	✔️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks

⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbol	Leaking sources
firehose	Pub	firehose/firehose.dart::Firehose::verify::pub

This check can be disabled by tagging the PR with skip-leaking-check.

Unused Dependencies ✔️

Package	Status
dart_flutter_team_lints	✔️ All dependencies utilized correctly.
firehose	✔️ All dependencies utilized correctly.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

License Headers ✔️

// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

This check can be disabled by tagging the PR with skip-license-check.

Coverage

⚠️

File	Coverage
pkgs/dart_flutter_team_lints/tool/dedup.dart	💔 Not covered
pkgs/firehose/lib/firehose.dart	💚 96 % ⬆️ 69 %
pkgs/firehose/lib/src/changelog.dart	💚 100 %
pkgs/firehose/lib/src/delayed_client.dart	💚 23 %
pkgs/firehose/lib/src/github.dart	💚 55 %
pkgs/firehose/lib/src/health/changelog.dart	💚 92 %
pkgs/firehose/lib/src/health/coverage.dart	💚 77 %
pkgs/firehose/lib/src/health/health.dart	💔 92 % ⬇️ 1 %
pkgs/firehose/lib/src/health/lcov.dart	💚 89 %
pkgs/firehose/lib/src/health/license.dart	💚 100 %
pkgs/firehose/lib/src/local_github_api.dart	💚 42 %
pkgs/firehose/lib/src/pub.dart	💚 93 %
pkgs/firehose/lib/src/repo.dart	💚 98 %
pkgs/firehose/lib/src/utils.dart	💚 90 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

natebosch · 2026-09-04T18:02:26Z

I like the idea of reusing the same code path we recommend to our users for this.

I don't think it should block us from implementing #448, but it might be worth a closer look to double check before we settle on this.

mosuem · 2026-09-07T08:29:50Z

Here is an example PR adopting this in dart-lang/labs: dart-lang/labs#374

mosuem · 2026-09-07T12:00:22Z

I think this should be independent of #448, that can just be a separate check in the health PR checks.

…al publish workflows

…sion tag

…precate firehose CLI

…ure status

…workflow_sha

…on check

…ts and files

# Conflicts: # .github/workflows/publish.yaml

pq · 2026-10-30T15:31:22Z

Hi! Where's the best place to look for a migration example?

Should I look at: dart-lang/labs#374?

(We're currently broken downstream: https://github.com/dart-lang/ai/actions/runs/41080059866/job/124146461567?pr=725.)

@natebosch @mosuem

/fyi @jakemac53

mosuem · 2026-10-31T01:54:00Z

@pq See also #478 - I am working on a revert, and will send out migration PRs after.

pq · 2026-10-31T02:32:53Z

Ah, cool. Thanks!

- Switch `.github/workflows/publish.yaml` to tag-triggered `dart-lang/setup-dart/.github/workflows/publish.yml@main` (`use-flutter: false`) after `dart-lang/ecosystem#454` removed `ecosystem/.github/workflows/publish.yaml`.

@mosuem

…flow (#4310) > [!NOTE] > This PR was generated by an AI coding agent (Jetski) on behalf of @mosuem. Migrates publishing validation and tag-triggered publishing to the split workflow architecture from `dart-lang/ecosystem#454`: - **`.github/workflows/health.yaml`**: Add PR health workflow running the `publish` check (`checks: "publish"`, `fail_on: "publish"`). - **`.github/workflows/post_summaries.yaml`**: Pin to `dart-lang/ecosystem` `main`, scope permissions, and watch `Health` instead of `Publish`. - **`.github/workflows/publish.yaml`**: Trigger only on `v*` tag pushes and delegate to `dart-lang/setup-dart/.github/workflows/publish.yml` (`use-flutter: false`).

Revisions updated by `dart tools/rev_sdk_deps.dart`. core (https://github.com/dart-lang/core/compare/d7bd45c..24e09c4): 24e09c4c Sun Nov 1 21:12:19 2026 +0000 dependabot[bot] Bump the github-actions group with 4 updates (dart-lang/core#1037) 87ac1b4c Fri Oct 30 16:02:43 2026 +0100 Michael Thomsen [os_detect] Deprecate package:os_detect in favor of package:platform (dart-lang/core#1003) 8debf335 Fri Oct 30 01:57:36 2026 +0530 Sahaja Pallapothula Clarify Characters equality and Unicode normalization (dart-lang/core#1031) ecosystem (https://github.com/dart-lang/ecosystem/compare/24b9ba8..f8faabf): f8faabf Sun Nov 1 18:16:20 2026 +0000 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/ecosystem#481) 27c2fc8 Sat Oct 31 12:36:53 2026 +0100 Moritz Fix publish workflow pins, add tag_prefix to health, and update docs (dart-lang/ecosystem#480) 05641a9 Sat Oct 31 09:56:42 2026 +0100 Moritz Restore deprecated publish.yaml workflow and firehose CLI entrypoint (dart-lang/ecosystem#479) 78abf72 Fri Oct 30 08:24:07 2026 -0700 Kevin Moore fix(repo_manage): use pub_semver for changelog -wip transitions (dart-lang/ecosystem#475) 0bfa654 Fri Oct 30 09:33:57 2026 +0100 Moritz Move publish check to health workflow and use individual package publishing workflows from `setup-dart` (dart-lang/ecosystem#454) adf7979 Thu Oct 29 23:46:49 2026 -0700 Kevin Moore test(firehose): use hasLength, containsPair, and isFalse (dart-lang/ecosystem#477) http (https://github.com/dart-lang/http/compare/c76dfb3..8c0d66a): 8c0d66a Fri Oct 30 09:54:41 2026 -0700 Brian Quinlan chore(cupertino_http): check ffigen generation (dart-lang/http#2044) c8737d1 Fri Oct 30 09:11:46 2026 +0100 Moritz chore(http): run Firefox tests with -headless instead of xvfb-run (dart-lang/http#2033) 05d0b18 Fri Oct 30 07:08:19 2026 +0100 Moritz fix(http2): make StreamException a StreamTransportException and forward ALPN errors to onError (dart-lang/http#2009) i18n (https://github.com/dart-lang/i18n/compare/4c7b4ad..7475ce6): 7475ce64 Sat Oct 31 02:49:28 2026 +0100 Moritz [intl4x] Fix NumberFormat.percent ignoring digits (dart-lang/i18n#1115) shelf (https://github.com/dart-lang/shelf/compare/62d3e4e..9946de5): 9946de5 Sun Nov 1 12:27:59 2026 +0000 dependabot[bot] build(deps): bump the github-actions group with 3 updates (dart-lang/shelf#554) test (https://github.com/dart-lang/test/compare/6d74720..2a9e017): 2a9e0175 Sun Nov 1 03:47:24 2026 +0000 dependabot[bot] Bump the github-actions group with 6 updates (dart-lang/test#2813) 55cd5cd5 Fri Oct 30 13:43:47 2026 -0700 Nate Bosch Migrate publishing workflows from firehose to setup-dart (dart-lang/test#2812) 10dc78c0 Fri Oct 30 11:21:53 2026 -0700 Nate Bosch [checks] Describe what the stream did in failures (dart-lang/test#2811) c11ad06d Fri Oct 30 08:59:57 2026 -0700 Nate Bosch [checks] Add CheckFailure.describeNested (dart-lang/test#2793) 0137b43e Fri Oct 30 05:40:43 2026 +0530 Shriraj Jadhav [checks] Use the Iterable.last member for the last expectation (dart-lang/test#2807) 50c9f454 Thu Oct 29 15:11:39 2026 -0700 Nate Bosch [checks] Collapse clauses for described conditions (dart-lang/test#2794) tools (https://github.com/dart-lang/tools/compare/3980dca..1579f8d): 1579f8d69 Mon Nov 2 02:44:58 2026 +0530 Joshua fix(coverage): reject package: and dart: URIs outside known roots in Resolver (dart-lang/tools#2764) f869fdca4 Sun Nov 1 10:26:34 2026 +0100 dart-ecosystem-bot[bot] [boring] Update BoringSSL to ed9209cf (dart-lang/tools#2774) d10e2b87f Sun Nov 1 10:26:11 2026 +0100 dart-ecosystem-bot[bot] [boring] Pin the prebuilt binaries of boring-binaries-20261101-33e9e69722af (dart-lang/tools#2777) 33e9e6972 Sun Nov 1 05:56:30 2026 +0000 dependabot[bot] build(deps): bump the github-actions group with 4 updates (dart-lang/tools#2775) f84d0d0d2 Sun Nov 1 05:36:12 2026 +0000 dependabot[bot] build(deps): bump ffigen from 22.0.0 to 23.0.0 in /pkgs/boring (dart-lang/tools#2776) 14ad5e515 Fri Oct 30 10:48:58 2026 -0700 Kevin Moore [mime] Harden BoundMultipartStream error routing, headers, and epilogue (dart-lang/tools#2629) 7a780d48c Fri Oct 30 12:57:03 2026 +0100 Jonas Finnemann Jensen [markdown] Avoid rescanning failed plain-text runs in InlineParser (dart-lang/tools#2757) 3671d33a9 Fri Oct 30 12:56:48 2026 +0100 Jonas Finnemann Jensen [markdown] Index footnote definitions and labels on Document for O(1) lookup (dart-lang/tools#2760) 6f38e9fda Fri Oct 30 12:56:09 2026 +0100 Jonas Finnemann Jensen [markdown] Bound the domain of extended URL autolinks to DNS limits (dart-lang/tools#2759) aa0c38544 Fri Oct 30 12:20:40 2026 +0100 Jonas Finnemann Jensen [markdown] Avoid quadratic removeRange in _combineAdjacentText (dart-lang/tools#2758) f425baf46 Fri Oct 30 11:16:28 2026 +0100 Jonas Finnemann Jensen [markdown] Avoid rescanning failed space runs in LineBreakSyntax (dart-lang/tools#2756) c7eafbec3 Fri Oct 30 11:09:45 2026 +0100 Jonas Finnemann Jensen [markdown] Reject '<' in AutolinkSyntax (dart-lang/tools#2755) 86ed0f902 Fri Oct 30 11:08:25 2026 +0100 Jonas Finnemann Jensen [markdown] Avoid quadratic backtracking in headerPattern (dart-lang/tools#2754) 8ea07517f Fri Oct 30 07:45:42 2026 +0100 Moritz [boring] Regenerate the x509-limbo expected failures in the refresh job (dart-lang/tools#2712) 40235c365 Thu Oct 29 14:46:17 2026 +0100 Jonas Finnemann Jensen [markdown] Make HtmlBlockSyntax.parseChildLines iterative (dart-lang/tools#2749) 0ff03f643 Thu Oct 29 14:41:33 2026 +0100 Jonas Finnemann Jensen [markdown] Avoid re-escaping nested image alt text in ImageSyntax.createNode (dart-lang/tools#2752) 784654d01 Thu Oct 29 14:37:11 2026 +0100 Jonas Finnemann Jensen [markdown] Add test cases covering parser and renderer edge cases (dart-lang/tools#2753) 4f2718ad8 Thu Oct 29 14:36:52 2026 +0100 Jonas Finnemann Jensen [markdown] Make Document._parseInlineContent iterative (dart-lang/tools#2750) cac1421d5 Thu Oct 29 14:17:06 2026 +0100 Jonas Finnemann Jensen [markdown] Avoid quadratic duplicate heading ID probing in HtmlRenderer (dart-lang/tools#2748) 66880bcd3 Thu Oct 29 14:11:27 2026 +0100 Jonas Finnemann Jensen [markdown] Check footnote label and empty map before scanning footnote keys (dart-lang/tools#2751) 7f8696523 Thu Oct 29 14:07:06 2026 +0100 Jonas Finnemann Jensen [markdown] Avoid quadratic blank-line lookahead in CodeBlockSyntax (dart-lang/tools#2747) 9da6bb291 Thu Oct 29 14:03:04 2026 +0100 Jonas Finnemann Jensen [markdown] Avoid exponential and quadratic backtracking in tablePattern (dart-lang/tools#2746) dartdoc is held back at db94437, before dart-lang/dartdoc#4312, because its mock SDK version changes conflict in the google3 3-way merge with the hotfix in cl/1005963642. native is held back at e0ca7c6, before dart-lang/native#3742, because deprecating `MacOSCodeConfig(targetVersion: ...)` causes a fatal `deprecated_member_use` diagnostic in `pkg/dartdev/lib/src/native_assets.dart`. web is held back at 4e60e61, before dart-lang/web#596, because it changes `package:web` signatures (e.g. `innerHTML=`, `parseFromString`, `Worker()`) from `JSAny` to `String` in ways that break callers in google3. Change-Id: I53d2cbde741c45b8fd33bca42742549819dd332b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/572780 Reviewed-by: Brian Quinlan <[email protected]> Commit-Queue: Nate Bosch <[email protected]>

github-actions Bot added package:firehose type-infra A repository infrastructure change or enhancement labels Sep 4, 2026

gemini-code-assist Bot reviewed Sep 4, 2026

View reviewed changes

Comment thread pkgs/firehose/lib/src/health/health.dart Resolved

Comment thread pkgs/firehose/lib/src/health/health.dart Resolved

mosuem changed the title ~~Add publish check to health workflow and use individual package publishing workflows~~ Move publish check to health workflow and use individual package publishing workflows from setup-dart Sep 4, 2026

mosuem mentioned this pull request Sep 7, 2026

Use ecosystem publishing workflow with publish check in health dart-lang/labs#374

Open

mosuem marked this pull request as ready for review September 7, 2026 12:05

mosuem requested a review from natebosch September 7, 2026 12:37

mosuem mentioned this pull request Oct 9, 2026

feat(firehose): disable publish release links pre-merge and enable on merge #463

Open

mosuem added this pull request to stack #464 October 9, 2026 12:20

mosuem mentioned this pull request Oct 9, 2026

Add roll validation health check to firehose #465

Open

mosuem removed this pull request from stack #464 October 9, 2026 13:21

mosuem added this pull request to stack #466 October 9, 2026 13:21

mosuem force-pushed the publish-check-in-health branch from 65c6a1f to 135f8b1 Compare October 12, 2026 07:27

mosuem added 13 commits October 22, 2026 06:09

feat(firehose): add publish check to health workflow and use individu…

d9efd82

…al publish workflows

chore(publish): pin setup-dart workflow to commit hash instead of ver…

a00b601

…sion tag

fix(health): address PR review comments for publish check

c95b7bd

refactor(firehose): remove unused validate and publish methods and de…

281ff8c

…precate firehose CLI

test(firehose): add golden files for publish health check

974bc22

test(firehose): update comment_publish golden files with dry-run fail…

0b99468

…ure status

test(firehose): update comment_publish_ignore_package golden file

3d8a9f8

refactor(firehose): delete bin/firehose.dart CLI executable

96f77eb

fix(ci): pin external firehose installation to workflow_sha

f264234

fix(ci): use job.workflow_sha in step env rather than with block

8450eb6

chore(health): order PR health checks in aggregated comment

6f7f5f2

chore(ci): simplify external firehose installation to always use job.…

d1e3238

…workflow_sha

fix(ci): pass WORKFLOW_SHA via env to satisfy zizmor template injecti…

529c0c9

…on check

mosuem added 3 commits October 22, 2026 06:11

chore(health): order PR health checks using numeric prefix on artifac…

f444cbd

…ts and files

chore(health): remove unnecessary directory check for single-comments

f131182

chore(publish): update setup-dart publish.yml SHA to latest branch head

449bdb4

mosuem force-pushed the publish-check-in-health branch from 82c9db0 to 449bdb4 Compare October 22, 2026 06:12

natebosch approved these changes Oct 27, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into publish-check-in-health

5b44404

# Conflicts: # .github/workflows/publish.yaml

mosuem merged commit 0bfa654 into main Oct 30, 2026
22 checks passed

mosuem deleted the publish-check-in-health branch October 30, 2026 08:34

pq mentioned this pull request Oct 30, 2026

[manual_evals] Bump SDK constraint to ^3.13.0 dart-lang/ai#725

Merged

This was referenced Oct 30, 2026

firehose: Deleting bin/firehose.dart broke pinned publish.yaml@<sha> #478

Closed

Migrate publish workflow to setup-dart@main kevmoo/lower_bound.dart#5

Merged

This was referenced Oct 31, 2026

Restore deprecated publish.yaml workflow and firehose CLI entrypoint #479

Merged

Fix publish workflow pins, add tag_prefix to health, and update docs #480

Merged

Navigation Menu

Repository navigation

Move publish check to health workflow and use individual package publishing workflows from `setup-dart` - #454

Move publish check to health workflow and use individual package publishing workflows from `setup-dart`#454
mosuem merged 17 commits into
mainfrom
publish-check-in-health

mosuem commented Sep 4, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Sep 4, 2026 •

edited

Loading

Uh oh!

natebosch commented Sep 4, 2026

Uh oh!

mosuem commented Sep 7, 2026 •

edited

Loading

Uh oh!

mosuem commented Sep 7, 2026

Uh oh!

Uh oh!

pq commented Oct 30, 2026

Uh oh!

mosuem commented Oct 31, 2026

Uh oh!

pq commented Oct 31, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mosuem commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1. Integrate publish check into PR Health

2. Replace monolithic publish.yaml with individual package workflows

3. Clean up obsolete firehose methods, executable, and workflows

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Health

Uh oh!

natebosch commented Sep 4, 2026

Uh oh!

mosuem commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mosuem commented Sep 7, 2026

Uh oh!

Uh oh!

pq commented Oct 30, 2026

Uh oh!

mosuem commented Oct 31, 2026

Uh oh!

pq commented Oct 31, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mosuem commented Sep 4, 2026 •

edited

Loading

2. Replace monolithic `publish.yaml` with individual package workflows

github-actions Bot commented Sep 4, 2026 •

edited

Loading

mosuem commented Sep 7, 2026 •

edited

Loading