Skip to content

firehose: Fix formatter error message - #405

Closed
kevmoo wants to merge 1 commit into
mainfrom
weird_format_warning
Closed

kevmoo wants to merge 1 commit into
mainfrom
weird_format_warning

Conversation

@kevmoo

@kevmoo kevmoo commented Mar 28, 2026

Copy link
Copy Markdown
Member

The associated analysis_options uses dart_flutter_team_lints

So dartfmt was logging a lot of errors. Fixes those

Also helped me find/fix dart-lang/dart_style#1818

The associated analysis_options uses dart_flutter_team_lints

So dartfmt was logging a lot of errors. Fixes those

Also helped me find/fix dart-lang/dart_style#1818

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the development dependencies across multiple test packages by replacing the lints package with dart_flutter_team_lints version ^3.0.0. These changes are applied consistently to pubspec.yaml files within the test_data directory. I have no feedback to provide.

@github-actions

github-actions Bot commented Mar 28, 2026 •

Copy link
Copy Markdown

PR Health

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

Unused Dependencies ✔️
Package Status
firehose ✔️ All dependencies utilized correctly.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
firehose Non-Breaking 0.13.0 0.13.2-wip 0.13.2-wip ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
""
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/blast_repo/bin/blast_repo.dart
pkgs/blast_repo/lib/src/action_version.dart
pkgs/blast_repo/lib/src/exact_file_tweak.dart
pkgs/blast_repo/lib/src/github.dart
pkgs/blast_repo/lib/src/github_action_resolver.dart
pkgs/blast_repo/lib/src/repo_tweak.dart
pkgs/blast_repo/lib/src/top_level.dart
pkgs/blast_repo/lib/src/tweaks/auto_publish_tweak.dart
pkgs/blast_repo/lib/src/tweaks/dependabot_tweak.dart
pkgs/blast_repo/lib/src/tweaks/drop_lint_tweak.dart
pkgs/blast_repo/lib/src/tweaks/github_action_tweak.dart
pkgs/blast_repo/lib/src/tweaks/mono_repo_tweak.dart
pkgs/blast_repo/lib/src/tweaks/no_reponse_tweak.dart
pkgs/blast_repo/lib/src/utils.dart
pkgs/blast_repo/test/auto_publish_test.dart
pkgs/blast_repo/test/dependabot_test.dart
pkgs/blast_repo/test/drop_lint_test.dart
pkgs/blast_repo/test/github_action_test.dart
pkgs/blast_repo/test/mono_repo_test.dart
pkgs/blast_repo/test/no_response_test.dart
pkgs/blast_repo/test/utils_test.dart
pkgs/canary/bin/canary.dart
pkgs/canary/test/canary_test.dart
pkgs/corpus/bin/deps.dart
pkgs/corpus/bin/usage.dart
pkgs/corpus/lib/api.dart
pkgs/corpus/lib/cache.dart
pkgs/corpus/lib/packages.dart
pkgs/corpus/lib/pub.dart
pkgs/corpus/lib/report.dart
pkgs/corpus/lib/surveyor.dart
pkgs/corpus/lib/usage.dart
pkgs/corpus/lib/utils.dart
pkgs/corpus/test/api_test.dart
pkgs/corpus/test/data/class_references.dart
pkgs/corpus/test/data/dart_extension_references.dart
pkgs/corpus/test/data/dart_library_references.dart
pkgs/corpus/test/data/dart_top_level_symbol_references.dart
pkgs/corpus/test/data/extension_references.dart
pkgs/corpus/test/data/library_references.dart
pkgs/corpus/test/data/top_level_symbol_references.dart
pkgs/corpus/test/pub_test.dart
pkgs/corpus/test/visitor_test.dart
pkgs/dart_flutter_team_lints/test/validate_test.dart
pkgs/dart_flutter_team_lints/tool/dedup.dart
pkgs/firehose/bin/firehose.dart
pkgs/firehose/bin/health.dart
pkgs/firehose/lib/firehose.dart
pkgs/firehose/lib/src/changelog.dart
pkgs/firehose/lib/src/delayed_client.dart
pkgs/firehose/lib/src/github.dart
pkgs/firehose/lib/src/health/changelog.dart
pkgs/firehose/lib/src/health/coverage.dart
pkgs/firehose/lib/src/health/health.dart
pkgs/firehose/lib/src/health/lcov.dart
pkgs/firehose/lib/src/health/license.dart
pkgs/firehose/lib/src/local_github_api.dart
pkgs/firehose/lib/src/pub.dart
pkgs/firehose/lib/src/repo.dart
pkgs/firehose/lib/src/utils.dart
pkgs/firehose/test/changelog_test.dart
pkgs/firehose/test/coverage_test.dart
pkgs/firehose/test/github_test.dart
pkgs/firehose/test/health_test.dart
pkgs/firehose/test/license_test.dart
pkgs/firehose/test/pub_test.dart
pkgs/firehose/test/repo_test.dart
pkgs/firehose/test/utils_test.dart
pkgs/repo_manage/bin/report.dart
pkgs/repo_manage/lib/branches.dart
pkgs/repo_manage/lib/contributors.dart
pkgs/repo_manage/lib/issue_transfer.dart
pkgs/repo_manage/lib/labels.dart
pkgs/repo_manage/lib/labels_update.dart
pkgs/repo_manage/lib/src/common.dart
pkgs/repo_manage/lib/weekly.dart
pkgs/sdk_triage_bot/bin/triage.dart
pkgs/sdk_triage_bot/lib/src/common.dart
pkgs/sdk_triage_bot/lib/src/gemini.dart
pkgs/sdk_triage_bot/lib/src/github.dart
pkgs/sdk_triage_bot/lib/src/prompts.dart
pkgs/sdk_triage_bot/lib/triage.dart
pkgs/sdk_triage_bot/test/fakes.dart
pkgs/sdk_triage_bot/test/triage_test.dart
pkgs/sdk_triage_bot/tool/bench.dart

This check can be disabled by tagging the PR with skip-license-check.

@kevmoo

kevmoo commented Mar 28, 2026

Copy link
Copy Markdown
Member Author

ugh. Nevermind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant