Skip to content

Consider omitting PR comments for PRs from forks #452

Open

Description

@natebosch

We currently use a pattern which is flagged by zizmor for posting comments from firehose health checks to PRs. It needs to use a workflow_run to elevate permissions enough to post a comment - when a PR comes from a fork there are tighter restrictions on the CI workflows by default because it's running untrusted code.

This pattern can be safe if no code from the PR can be executed in the action, but we can't automatically verify that our usage is safe. #451 tightens some non-meaningful vulnerabilities where a malicious actor could get us to write a comment in the wrong place and I'm reasonably confident that the existing usage is safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions