Skip to content

Empty string for "warn_on" causes failure #303

Open

Description

@jakemac53

If you do warn_on: "", then the job fails with FormatException: "--ignore_license" is not an allowed value for option "warn_on"..

Presumably, it ends up passing --warn_on --ignore_license with nothing between since the string is empty. The argument shouldn't be passed at all or something probably.

Activity

  1. added
    type-bugIncorrect behavior (everything from a crash to more subtle misbehavior)
    on Oct 2, 2024
  2. jakemac53 commented on Oct 2, 2024

    @jakemac53
    ContributorAuthor

    Fwiw, in general it is difficult to just move a job from default warning to default failure. You have to override the entire setting, with all the default failure jobs, and also override the warn_on settings to remove the job from that, but leave the old ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    package:firehosetype-bugIncorrect behavior (everything from a crash to more subtle misbehavior)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions