Repository navigation
Commit fc3dd9a
authored
fix(firehose): update existing publishing PR comments when no packages are ready to publish (#449)
## Rationale
When a PR initially has a publishable version (e.g. `4.0.1-dev`) and firehose posts the `Package publishing` comment, but subsequently updates the package to a `-wip` version (e.g. `4.0.1-wip`), `VerificationResults.hasSuccess` becomes `false`.
Previously:
- In `lib/firehose.dart`, saving `existingCommentId` to `./output/commentId` and generating `./output/comment.md` was guarded strictly by `if (results.hasSuccess)`. When `hasSuccess` was `false`, neither file was written.
- As a result, the existing `Package publishing` comment with outdated `ready to publish` status and release links was never updated and remained on the PR indefinitely.
## Changes
- **`lib/firehose.dart`**: Save `existingCommentId` to `./output/commentId` unconditionally whenever an existing publishing comment is found. When `results.hasSuccess || existingCommentId != null`, write `./output/comment.md` with the updated `$markdownTable` (omitting the `"If you have publishing permissions..."` description when no packages are ready to publish).
- **`lib/src/github.dart`** & **`lib/src/local_github_api.dart`**: Add `deleteComment` helper to `GithubApi`.
- **`bin/comment.dart`**: Add `delete` subcommand (`firehose:comment delete --comment-id <id>`).
- **`test/firehose_test.dart`**: Add CLI argument validation and exit code tests for `comment delete`.
- **`CHANGELOG.md`**: Note that existing publishing PR comments are updated with accurate status when packages are no longer ready to publish.1 parent e0a78b4 commit fc3dd9a
6 files changed
Lines changed: 74 additions & 14 deletions
File tree
- pkgs/firehose
- bin
- lib
- src
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
5 | 8 | | |
6 | 9 | | |
7 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| 39 | + | |
| 40 | + | |
39 | 41 | | |
40 | 42 | | |
41 | 43 | | |
| |||
54 | 56 | | |
55 | 57 | | |
56 | 58 | | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
57 | 63 | | |
58 | 64 | | |
59 | 65 | | |
| |||
143 | 149 | | |
144 | 150 | | |
145 | 151 | | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | | - | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
84 | 94 | | |
85 | | - | |
| 95 | + | |
86 | 96 | | |
87 | 97 | | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | 98 | | |
97 | 99 | | |
98 | 100 | | |
99 | 101 | | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
104 | 106 | | |
105 | 107 | | |
106 | 108 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
135 | 138 | | |
136 | 139 | | |
137 | 140 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
47 | 50 | | |
48 | 51 | | |
49 | 52 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
143 | 164 | | |
0 commit comments