Skip to content

Commit b79f68c

Browse files
authored
chore(health): remove 3rd-party coveralls action dependency (#446)
1 parent cda8bd5 commit b79f68c

5 files changed

Lines changed: 2 additions & 23 deletions

File tree

‎.github/workflows/health.yaml‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ name: Health
2525
# fail_on: "changelog,do-not-submit"
2626
# warn_on: "license,coverage,breaking,leaking"
2727
# coverage_web: false
28-
# upload_coverage: false
2928
# flutter_packages: "pkgs/my_flutter_package"
3029
# ignore_license: "**.g.dart"
3130
# ignore_changelog: ""
@@ -81,11 +80,6 @@ on:
8180
default: false
8281
type: boolean
8382
required: false
84-
upload_coverage:
85-
description: Whether to upload the coverage to coveralls
86-
default: true
87-
type: boolean
88-
required: false
8983
coverage_web:
9084
description: Whether to run `dart test -p chrome` for coverage
9185
default: false
@@ -251,7 +245,6 @@ jobs:
251245
check: coverage
252246
fail_on: ${{ inputs.fail_on }}
253247
warn_on: ${{ inputs.warn_on }}
254-
upload_coverage: ${{ inputs.upload_coverage }}
255248
coverage_web: ${{ inputs.coverage_web }}
256249
local_debug: ${{ inputs.local_debug }}
257250
flutter_packages: ${{ inputs.flutter_packages }}

‎.github/workflows/health_base.yaml‎

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,6 @@ on:
3030
default: false
3131
type: boolean
3232
required: false
33-
upload_coverage:
34-
default: true
35-
type: boolean
36-
required: false
3733
coverage_web:
3834
default: false
3935
type: boolean
@@ -231,15 +227,6 @@ jobs:
231227
env:
232228
INPUTS_CHECK: ${{ inputs.check }}
233229

234-
- name: Upload coverage to Coveralls
235-
if: ${{ inputs.upload_coverage && inputs.check == 'coverage' }}
236-
uses: coverallsapp/github-action@5cbfd81b66ca5d10c19b062c04de0199c215fb6e
237-
with:
238-
format: lcov
239-
base-path: current_repo/
240-
compare-sha: ${{ github.event.pull_request.base.ref }}
241-
allow-empty: true
242-
243230
- name: Upload markdown
244231
if: success() || failure()
245232
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a

‎.github/workflows/health_internal.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ jobs:
1414
sdk: dev
1515
local_debug: true
1616
coverage_web: false
17-
upload_coverage: false
1817
checks: changelog,license,coverage,breaking,do-not-submit,leaking,unused-dependencies
1918
fail_on: changelog,do-not-submit
2019
warn_on: license,coverage,breaking,leaking,unused-dependencies
2120
ignore_license: 'pkgs/firehose/test_data'
2221
ignore_coverage: 'pkgs/firehose/bin,pkgs/firehose/test_data'
22+
ignore_donotsubmit: 'pkgs/firehose/README.md,pkgs/firehose/test_data'
2323
health_yaml_name: 'health_internal.yaml'
2424
permissions:
2525
pull-requests: write

‎pkgs/firehose/CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
## 0.13.2-wip
22

3+
- Remove 3rd-party Coveralls action and `upload_coverage` input from health workflows.
34
- Add `--tag-prefix` option to `firehose` and `tag-prefix` input to `publish.yaml` to allow configuring the release tag prefix (defaults to `'v'`).
45
- Run `pub get` before `dart format` in `groundskeeper`.
56
- Add `groundskeeper` executable to format and fix packages.

‎pkgs/firehose/README.md‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,6 @@ jobs:
182182
# fail_on: "version,changelog,do-not-submit"
183183
# warn_on: "license,coverage,breaking,leaking"
184184
# coverage_web: false
185-
# upload_coverage: false
186185
# use-flutter: true
187186
# ignore_license: "**.g.dart"
188187
# ignore_coverage: "**.mock.dart,**.g.dart"
@@ -234,7 +233,6 @@ jobs:
234233
| `checks` | List of strings | What to check for in the PR health check | `"changelog,license,coverage,breaking,do-not-submit,leaking,unused-dependencies"` |
235234
| `fail_on` | List of strings | Which checks should lead to failure | `"changelog,do-not-submit"` |
236235
| `warn_on` | List of strings | Which checks should not fail, but only warn | `"license,coverage,breaking,leaking"` |
237-
| `upload_coverage` | boolean | Whether to upload the coverage to [coveralls](https://coveralls.io/) | `true` |
238236
| `coverage_web` | boolean | Whether to run `dart test -p chrome` for coverage | `false` |
239237
| `flutter_packages` | List of strings | List of packages depending on Flutter | `"pkgs/intl_flutter"` |
240238
| `ignore_*` | List of globs | Files to ignore, where `*` can be `license`, `changelog`, `coverage`, `breaking`, `leaking`, `donotsubmit`, or `unuseddependencies`. For the `breaking` and `unuseddependencies` checks, the glob should be all files of the package. | `"**.g.dart"` |

0 commit comments

Comments
 (0)