Skip to content

Commit adf7979

Browse files
authored
test(firehose): use hasLength, containsPair, and isFalse (#477)
1 parent 24b9ba8 commit adf7979

2 files changed

Lines changed: 27 additions & 13 deletions

File tree

‎pkgs/firehose/test/firehose_test.dart‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ void main() {
3737
..addResult(Result.info(pkgB, Result.alreadyPublishedMessage,
3838
isAffected: true));
3939

40-
expect(results.visibleResults.length, 2);
40+
expect(results.visibleResults, hasLength(2));
4141
expect(results.hiddenResults, isEmpty);
4242

4343
final markdown = results.describeAsMarkdown(withTag: false);
@@ -53,7 +53,7 @@ void main() {
5353
Result.success(pkgA, '**ready to publish**', isAffected: false))
5454
..addResult(Result.fail(pkgB, 'version mismatch', isAffected: false));
5555

56-
expect(results.visibleResults.length, 2);
56+
expect(results.visibleResults, hasLength(2));
5757
expect(results.hiddenResults, isEmpty);
5858

5959
final markdown = results.describeAsMarkdown(withTag: false);
@@ -72,8 +72,8 @@ void main() {
7272
..addResult(Result.info(pkgE, Result.alreadyPublishedMessage,
7373
isAffected: false));
7474

75-
expect(results.visibleResults.length, 2);
76-
expect(results.hiddenResults.length, 3);
75+
expect(results.visibleResults, hasLength(2));
76+
expect(results.hiddenResults, hasLength(3));
7777

7878
final markdown = results.describeAsMarkdown(withTag: false);
7979
expect(markdown, contains('| package:pkg_1 |'));
@@ -104,7 +104,7 @@ void main() {
104104
..addResult(Result.info(pkgB, Result.wipMessage, isAffected: false));
105105

106106
expect(results.visibleResults, isEmpty);
107-
expect(results.hiddenResults.length, 2);
107+
expect(results.hiddenResults, hasLength(2));
108108

109109
final markdown = results.describeAsMarkdown(withTag: false);
110110
expect(

‎pkgs/firehose/test/repo_test.dart‎

Lines changed: 22 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ void main() {
3333

3434
test('isSinglePackageRepo', () {
3535
final result = packages.isSinglePackageRepo;
36-
expect(result, false);
36+
expect(result, isFalse);
3737
});
3838

3939
test('locatePackages', () {
@@ -62,10 +62,21 @@ void main() {
6262
expect(releaseUri.path, '/${github.repoSlug}/releases/new');
6363

6464
final queryParams = releaseUri.queryParameters;
65-
expect(queryParams['tag'], packages.calculateRepoTag(package));
66-
expect(queryParams['title'],
67-
allOf(contains(package.name), contains(package.version.toString())));
68-
expect(queryParams['body'], package.changelog.describeLatestChanges);
65+
expect(
66+
queryParams,
67+
containsPair('tag', packages.calculateRepoTag(package)),
68+
);
69+
expect(
70+
queryParams,
71+
containsPair(
72+
'title',
73+
allOf(contains(package.name), contains(package.version.toString())),
74+
),
75+
);
76+
expect(
77+
queryParams,
78+
containsPair('body', package.changelog.describeLatestChanges),
79+
);
6980
});
7081

7182
test('github release link with custom prefix', () {
@@ -82,10 +93,13 @@ void main() {
8293

8394
final queryParams = releaseUri.queryParameters;
8495
expect(
85-
queryParams['tag'],
86-
packages.calculateRepoTag(package, tagPrefix: ''),
96+
queryParams,
97+
containsPair('tag', packages.calculateRepoTag(package, tagPrefix: '')),
98+
);
99+
expect(
100+
queryParams,
101+
containsPair('tag', '${package.name}-${package.pubspec.version}'),
87102
);
88-
expect(queryParams['tag'], '${package.name}-${package.pubspec.version}');
89103
});
90104
});
91105

0 commit comments

Comments
 (0)